Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add single prop #3

Merged
merged 1 commit into from
Jul 19, 2021
Merged

Add single prop #3

merged 1 commit into from
Jul 19, 2021

Conversation

ShirasawaSama
Copy link
Contributor

@ShirasawaSama ShirasawaSama commented Jul 19, 2021

🤔 This is a ...

  • New feature
  • Bug fix
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • README update
  • Other (about what?)

🔗 Related issue link

Some CustomSelect are not closed after selection.

💡 Background and solution

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Demo in storybook is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • README API section is updated or not needed

Copy link
Owner

@baymac baymac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! There are few more Autocomplete fields that don't close due to re-renders but at least this partially fixes for some fields.

@baymac baymac merged commit 7f7bb13 into baymac:master Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants