Merge pull request #62 from baynezy/feature/issue-61-sonar

Fix sonar recommendations
baynezy · Feb 12, 2024 · c52db9a · c52db9a
2 parents fe5e529 + a00084e
commit c52db9a
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 6 deletions.
diff --git a/src/Console/Factories/ConfigFactory.cs b/src/Console/Factories/ConfigFactory.cs
@@ -3,7 +3,7 @@
 
 namespace Console.Factories;
 
-public class ConfigFactory
+public static class ConfigFactory
 {
     public static IConfig Create(List<string> input)
     {

diff --git a/src/Console/Factories/LoggerFactory.cs b/src/Console/Factories/LoggerFactory.cs
@@ -2,7 +2,7 @@
 
 namespace Console.Factories;
 
-public class LoggerFactory
+public static class LoggerFactory
 {
     public static ILogger Create(bool? logError)
     {

diff --git a/src/Console/Factories/WarmerFactory.cs b/src/Console/Factories/WarmerFactory.cs
@@ -5,7 +5,7 @@
 
 namespace Console.Factories;
 
-public class WarmerFactory
+public static class WarmerFactory
 {
     public static Warmer Create(int? retries, IConfig config, IRequester requester, ILogger logger)
     {

diff --git a/src/SiteWarmer.Core/Logging/ConsoleLogger.cs b/src/SiteWarmer.Core/Logging/ConsoleLogger.cs
@@ -7,7 +7,7 @@ namespace SiteWarmer.Core.Logging;
 /// </summary>
 public class ConsoleLogger : ILogger
 {
-    private static ConsoleColor _originalTextColour;
+    private static readonly ConsoleColor OriginalTextColour = Console.ForegroundColor;
     private static readonly object LockObject = new();
     private const ConsoleColor ErrorTextColour = ConsoleColor.Red;
     private const ConsoleColor ContentFailTextColour = ConsoleColor.Yellow;
@@ -18,7 +18,6 @@ public class ConsoleLogger : ILogger
     /// </summary>
     public ConsoleLogger()
     {
-        _originalTextColour = Console.ForegroundColor;
     }
 
     public void Log(Check check)
@@ -66,7 +65,7 @@ private static void WriteToConsoleInColour(Check check, string passed, ConsoleCo
         {
             Console.ForegroundColor = textColour;
             WriteToConsole(check, passed);
-            Console.ForegroundColor = _originalTextColour;	
+            Console.ForegroundColor = OriginalTextColour;	
         }
     }