bug: Fix search result cycling when using different search term #6
+6
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there! thanks for making this great tool!
Bug
I found a subtle bug in the search functionality. Basically when I hit the "Enter" key with the search term "first_dep" and then change my search term to "second_dep", hitting the "Enter" key again would still cycle me through the results of "first_dep"
NOTE: this doesn't happen if i were to manually click the search icon
Fix
The fix i made was pretty straightforward -- i added a
lastSearch
term to track changes in the search inputThe code now correctly handles transitions between different search terms when hitting "Enter" key