-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support multiple packages in the same directory #7
Comments
It has become a lower priority FR for me atm. The most critical thing for all Bazel go project is to maintain the compatibility with the standard go toolchain — that’s the way to get out of box code completion, in-line document look up etc. Unless we have a better approach for solving that, I don’t think this worth the effort. Of course it will be useful when open sourcing a google project. |
- Add go_package attributes to the .proto files, so that protoc can properly generate imports for files that are linked together. - Manually add go_proto_library/go_library tags. Due to multiple .proto files being stored in one directory, Gazelle is not capable of automatically generating rules for them. See bazel-contrib/bazel-gazelle#7 for details.
How should we import repositories that have multiple packages in one directory? For example Can we specify which package to use for the build file? |
I just ran into the issue with https://github.com/rivo/uniseg. It would be nice if we could specify the package we cared about |
(Originally bazel-contrib/rules_go#315)
We should consider supporting projects with multiple Go packages in the same directory. "go build" does not allow this, but it is fairly common within Google, and some projects being open-sourced by Google have expressed interest in this.
#5 (naming rules after Go packages) is probably a prerequisite.
The text was updated successfully, but these errors were encountered: