Add rule.AttrComments func #1394
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcj
force-pushed
the
pcj/attr-comments
branch
from
03f094a to
f045255
Compare
|
@pcj I think this is a lot more in line with what I would have expected. That said, it still has us exporting a non-primitive type from another package into our public API. Not asking you to do any code writing on this front, but curious about a couple of things.
|
|
Hi @pcj! |
|
This was done in #1700 |
|
Glad to see this was finally merged, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What package or component does this PR mostly affect?
What does this PR do? Why is it needed?
Allows programmatic access to the assignment expression comments.
Which issues(s) does this PR fix?
Fixes #1389