refactor: change pathTrie per-file to per-directory #1931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbedard
force-pushed
the
trie-per-dir
branch
2 times, most recently
from
3059c4a
to
1766140
Compare
jbedard
force-pushed
the
trie-per-dir
branch
2 times, most recently
from
e2dfe45
to
572327d
Compare
fmeum
reviewed
Oct 30, 2024
fmeum
approved these changes
Nov 7, 2024
|
Windows is broken? 😒 |
|
Fixed it on master and rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the
pathTriealigns with the directory tree, not full fs tree which includes files. Aligning with the directory tree makes more sense to me, and I think will make it simpler to do things like load BUILDs concurrently while doing the fs-traversal (and persisting that in thepathTrie) etc.What type of PR is this?
What package or component does this PR mostly affect?
What does this PR do? Why is it needed?
Performance + simplifying things for future changes.