Skip to content

Commit

Permalink
fix: use test command for test flags
Browse files Browse the repository at this point in the history
I don't think there's any reason we apply these two flags for `build`?
  • Loading branch information
alexeagle committed Apr 13, 2023
1 parent e30284f commit 06eed43
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions .aspect/bazelrc/ci.bazelrc
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
# or split up into multiple test targets with sharding or manually.
# Set this flag to exclude targets that have their timeout set to eternal (>15m) from running on CI.
# Docs: https://bazel.build/docs/user-manual#test-timeout-filters
build --test_timeout_filters=-eternal
test --test_timeout_filters=-eternal

# Set this flag to enable re-tries of failed tests on CI.
# When any test target fails, try one or more times. This applies regardless of whether the "flaky"
Expand All @@ -16,7 +16,7 @@ build --test_timeout_filters=-eternal
# is more likely to get fixed.
# Note that when passing after the first attempt, Bazel will give a special "FLAKY" status.
# Docs: https://bazel.build/docs/user-manual#flaky-test-attempts
build --flaky_test_attempts=2
test --flaky_test_attempts=2

# Announce all announces command options read from the bazelrc file(s) when starting up at the
# beginning of each Bazel invocation. This is very useful on CI to be able to inspect what Bazel rc
Expand Down
4 changes: 2 additions & 2 deletions lib/tests/bazelrc_presets/all/ci.bazelrc
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
# or split up into multiple test targets with sharding or manually.
# Set this flag to exclude targets that have their timeout set to eternal (>15m) from running on CI.
# Docs: https://bazel.build/docs/user-manual#test-timeout-filters
build --test_timeout_filters=-eternal
test --test_timeout_filters=-eternal

# Set this flag to enable re-tries of failed tests on CI.
# When any test target fails, try one or more times. This applies regardless of whether the "flaky"
Expand All @@ -16,7 +16,7 @@ build --test_timeout_filters=-eternal
# is more likely to get fixed.
# Note that when passing after the first attempt, Bazel will give a special "FLAKY" status.
# Docs: https://bazel.build/docs/user-manual#flaky-test-attempts
build --flaky_test_attempts=2
test --flaky_test_attempts=2

# Announce all announces command options read from the bazelrc file(s) when starting up at the
# beginning of each Bazel invocation. This is very useful on CI to be able to inspect what Bazel rc
Expand Down

0 comments on commit 06eed43

Please sign in to comment.