fix: allow copy_to_directory to have an empty srcs list (#871)

bazel-contrib · Jun 21, 2024 · 18ae5a8 · 18ae5a8
1 parent 3330c38
commit 18ae5a8
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 3 deletions.
diff --git a/lib/private/copy_to_directory.bzl b/lib/private/copy_to_directory.bzl
@@ -461,9 +461,6 @@ def copy_to_directory_bin_action(
  })
  file_inputs.append(f.file)
 
- if not file_inputs:
- fail("No files to copy")
-
  config = {
  "allow_overwrites": allow_overwrites,
  "dst": dst.path,

diff --git a/lib/tests/copy_to_directory/BUILD.bazel b/lib/tests/copy_to_directory/BUILD.bazel
@@ -449,3 +449,22 @@ diff_test(
  file1 = "case_21",
  file2 = ":expected_21",
 )
+
+# Case 22: empty sources creates an empty directory output
+copy_to_directory(
+ name = "case_22",
+ srcs = [],
+)
+
+copy_to_directory(
+ name = "expected_22",
+ srcs = ["dir_expected_22"],
+ exclude_srcs_patterns = ["**/filter_me_out"],
+)
+
+diff_test(
+ name = "case_22_test",
+ file1 = "case_22",
+ file2 = ":expected_22",
+ tags = ["local"], # seems that the Bazel sandbox has trouble with empty directories
+)
diff --git a/lib/tests/copy_to_directory/dir_expected_22/filter_me_out b/lib/tests/copy_to_directory/dir_expected_22/filter_me_out