perf: remove unnecessary calls to 'to_list' (#737)

bazel-contrib · Jan 29, 2024 · 59cc705 · 59cc705
1 parent f0a19f5
commit 59cc705
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/lib/private/copy_directory_toolchain.bzl b/lib/private/copy_directory_toolchain.bzl
@@ -57,7 +57,7 @@ CopyToDirectoryInfo = provider(
 )
 
 def _copy_directory_toolchain_impl(ctx):
-    binary = ctx.attr.bin.files.to_list()[0]
+    binary = ctx.file.bin
 
     default_info = DefaultInfo(
         files = depset([binary]),

diff --git a/lib/private/copy_to_directory_toolchain.bzl b/lib/private/copy_to_directory_toolchain.bzl
@@ -57,7 +57,7 @@ CopyToDirectoryInfo = provider(
 )
 
 def _copy_to_directory_toolchain_impl(ctx):
-    binary = ctx.attr.bin.files.to_list()[0]
+    binary = ctx.file.bin
 
     default_info = DefaultInfo(
         files = depset([binary]),

diff --git a/lib/private/jq_toolchain.bzl b/lib/private/jq_toolchain.bzl
@@ -65,7 +65,7 @@ JqInfo = provider(
 )
 
 def _jq_toolchain_impl(ctx):
-    binary = ctx.attr.bin.files.to_list()[0]
+    binary = ctx.file.bin
 
     # Make the $(JQ_BIN) variable available in places like genrules.
     # See https://docs.bazel.build/versions/main/be/make-variables.html#custom_variables

diff --git a/lib/private/yq_toolchain.bzl b/lib/private/yq_toolchain.bzl
@@ -314,7 +314,7 @@ YqInfo = provider(
 )
 
 def _yq_toolchain_impl(ctx):
-    binary = ctx.attr.bin.files.to_list()[0]
+    binary = ctx.file.bin
 
     # Make the $(YQ_BIN) variable available in places like genrules.
     # See https://docs.bazel.build/versions/main/be/make-variables.html#custom_variables