chore: apply lint fixes

CONTRIBUTING.md

@@ -1,8 +1,8 @@
-# How to Contribute
+# How to contribute
 
 ## Formatting
 
-Starlark files should be formatted by buildifier.
+Starlark files should be formatted by Buildifier.
 We suggest using a pre-commit hook to automate this.
 First [install pre-commit](https://pre-commit.com/#installation) (>= v3.2.0),
 then run

lib/tests/run_binary_expansions/expansions.sh

@@ -1,12 +1,12 @@
 #!/usr/bin/env bash
 set -o errexit -o nounset -o pipefail
 
-mkdir -p $(dirname $1)
+mkdir -p $(dirname "$1")
 outfile=$1
-rm -f $outfile
+rm -f "$outfile"
 for each in $@; do
   sanitized=${each/darwin/PLATFORM}
   sanitized=${sanitized/k8/PLATFORM}
   sanitized=${sanitized/_arm64/}
-  echo $sanitized >>$outfile
+  echo "$sanitized" >>"$outfile"
 done

lib/tests/stamping/stamper.sh

@@ -6,8 +6,8 @@ set -o nounset
 # is another option, which requires Bash 4 for associative arrays.
 while IFS= read -r line; do
   read key value <<<"$line"
-  declare $key="$value"
+  declare "$key"="$value"
 done < <(cat "${BAZEL_STABLE_STATUS_FILE:-/dev/null}" "${BAZEL_VOLATILE_STATUS_FILE:-/dev/null}")
 
 # A real program would do something useful with the stamp info, like pass it to a linker.
-echo "${BUILD_USER:-unstamped}" >$1
+echo "${BUILD_USER:-unstamped}" >"$1"

tools/release/copy_release_artifacts.sh

@@ -25,7 +25,7 @@ if [[ -z "${DEST:-}" ]]; then
   exit 1
 fi
 
-cd $BUILD_WORKSPACE_DIRECTORY
+cd "$BUILD_WORKSPACE_DIRECTORY"
 for arg in "$@"; do
-  cp -pv "$(rlocation $arg)" $DEST
+  cp -pv "$(rlocation "$arg")" "$DEST"
 done