chore: try to see why diff tests fail on windows

bazel-contrib · Oct 10, 2023 · 801d4ba · 801d4ba
1 parent 70418b1
commit 801d4ba
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 0 deletions.
diff --git a/internal_deps.bzl b/internal_deps.bzl
@@ -30,6 +30,8 @@ def bazel_lib_internal_deps():
 
     http_archive(
         name = "bazel_skylib",
+        patch_args = ["-p1"],
+        patches = ["//:skylib.patch"],
         sha256 = "66ffd9315665bfaafc96b52278f57c7e2dd09f5ede279ea6d39b2be471e7e3aa",
         urls = [
             "https://github.com/bazelbuild/bazel-skylib/releases/download/1.4.2/bazel-skylib-1.4.2.tar.gz",

diff --git a/skylib.patch b/skylib.patch
@@ -0,0 +1,15 @@
+diff --git a/rules/diff_test.bzl b/rules/diff_test.bzl
+index 0f27f35..53d680b 100644
+--- a/rules/diff_test.bzl
++++ b/rules/diff_test.bzl
+@@ -171,9 +171,6 @@ def diff_test(name, file1, file2, failure_message = None, **kwargs):
+         file1 = file1,
+         file2 = file2,
+         failure_message = failure_message,
+-        is_windows = select({
+-            "@bazel_tools//src/conditions:host_windows": True,
+-            "//conditions:default": False,
+-        }),
++        is_windows = False,
+         **kwargs
+     )