Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: write_source_files does not copy hidden files #667

Closed
kormide opened this issue Nov 20, 2023 · 1 comment
Closed

[Bug]: write_source_files does not copy hidden files #667

kormide opened this issue Nov 20, 2023 · 1 comment
Labels
bug Something isn't working untriaged Requires traige

Comments

@kormide
Copy link
Collaborator

kormide commented Nov 20, 2023

What happened?

Files that begin with a . are not copied, regardless of whether the source is in the source tree or the output tree.

Version

Development (host) and target OS/architectures:

Output of bazel --version: 6.3.2

Version of the Aspect rules, or other relevant rules from your
WORKSPACE or MODULE.bazel file:

Language(s) and/or frameworks involved: 2.0.1

How to reproduce

Include a hidden file in a write_source_files targets. Observe that it does not get written.

Any other information?

I have a patch in this PR to fix it: aspect-build/rules_js#1366

However, it does not copy executable bits. That may be a separate issue related to #526, however.

@kormide kormide added the bug Something isn't working label Nov 20, 2023
@github-actions github-actions bot added the untriaged Requires traige label Nov 20, 2023
@jgiles
Copy link
Contributor

jgiles commented Jun 3, 2024

@kormide I think #860 should resolve.

@github-project-automation github-project-automation bot moved this to ✅ Done in Open Source Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working untriaged Requires traige
Projects
None yet
Development

No branches or pull requests

2 participants