-
-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Directory hidden files in write_source_file. #860
fix: Directory hidden files in write_source_file. #860
Conversation
Copy and manage hidden files starting with "." in write_source_files. Previously these files were not supported if they were in the top level of the directory to copy.
Thanks! Can you add a test? |
Hey @kormide, I took a stab at adding a test, let me know if that's the right structure. I also adjusted some of the commands - chmod and cp, without |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for fixing this old issue! I'll wait for the CI run to pass before clicking approve.
Copy and manage hidden files starting with "." in write_source_files.
Previously these files were not supported if they were in the top level of the directory to copy.
Refs: #667
Changes are visible to end-users: yes/no
Test plan