Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use robocopy in copy_file#is_directory and copy_to_directory #26

Merged
merged 1 commit into from
Jan 27, 2022
Merged

fix: use robocopy in copy_file#is_directory and copy_to_directory #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions lib/private/copy_file.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,23 +50,24 @@ def copy_cmd(ctx, src, dst):

# Flags are documented at
# https://docs.microsoft.com/en-us/windows-server/administration/windows-commands/copy
# https://docs.microsoft.com/en-us/windows-server/administration/windows-commands/xcopy
# https://docs.microsoft.com/en-us/windows-server/administration/windows-commands/robocopy
# NB: robocopy return non-zero exit codes on success so we must exit 0 after calling it
if dst.is_directory:
cmd_tmpl = "@xcopy \"%s\" \"%s\\\" /V /E /H /Y /Q >NUL"
cmd_tmpl = "@robocopy \"{src}\" \"{dst}\" /E >NUL & @exit 0"
mnemonic = "CopyDirectory"
progress_message = "Copying directory"
progress_message = "Copying directory %s" % src.path
else:
cmd_tmpl = "@copy /Y \"%s\" \"%s\" >NUL"
cmd_tmpl = "@copy /Y \"{src}\" \"{dst}\" >NUL"
mnemonic = "CopyFile"
progress_message = "Copying file"
progress_message = "Copying file %s" % src.path

ctx.actions.write(
output = bat,
# Do not use lib/shell.bzl's shell.quote() method, because that uses
# Bash quoting syntax, which is different from cmd.exe's syntax.
content = cmd_tmpl % (
src.path.replace("/", "\\"),
dst.path.replace("/", "\\"),
content = cmd_tmpl.format(
src = src.path.replace("/", "\\"),
dst = dst.path.replace("/", "\\"),
),
is_executable = True,
)
Expand Down
7 changes: 5 additions & 2 deletions lib/private/copy_to_directory.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,15 +197,15 @@ mkdir "%s" >NUL 2>NUL

# copy & xcopy flags are documented at
# https://docs.microsoft.com/en-us/windows-server/administration/windows-commands/copy
# https://docs.microsoft.com/en-us/windows-server/administration/windows-commands/xcopy
# https://docs.microsoft.com/en-us/windows-server/administration/windows-commands/robocopy
cmds.append("""
if not exist "{src}" (
echo file "{src}" does not exist
exit /b 1
)
if exist "{src}\\*" (
mkdir "{dst}" >NUL 2>NUL
xcopy "{src}\\*" "{dst}" /V /E /H /Y /Q >NUL
robocopy "{src}" "{dst}" /E >NUL
) else (
mkdir "{dst_dir}" >NUL 2>NUL
copy /Y "{src}" "{dst}" >NUL
Expand All @@ -216,6 +216,9 @@ if exist "{src}\\*" (
dst = dst_path.replace("/", "\\"),
))

# robocopy return non-zero exit codes on success so we must exit 0 when we are done
cmds.append("exit 0")

ctx.actions.write(
output = bat,
# Do not use lib/shell.bzl's shell.quote() method, because that uses
Expand Down