chore: use coreutils hashsum

[thesayyn]

No description provided.

[gregmagolan]

Should document the new dep on the core_utils toolchain for the hashes rule.

EDIT: actually the only way to make it non-breaking is to always register the toolchain like we did for the new copy_to_directory toolchain: https://github.com/aspect-build/bazel-lib/blob/4dc36a97f23c3a925142d4bd923be029ee1fe522/lib/repositories.bzl#L38

[gregmagolan]

Will also need to add a test for hashes to e2e/bzlmod & e2e/workspace for this one :)

[thesayyn]

done.

[thesayyn]

adding derek as a reviewer as he knows the repo and bzlmod

[kormide]

I think you could add to the existing e2e/workspace and e2e/bzlmod, just one usage (e.g., a genrule) as a smoke test that workspace/e2e users are able to use the toolchain. We do the same in those e2es for other toolchains. For the most part unit tests can exercise coreutils, and eventually we'll be running all unit tests with bzlmod enabled on ci, so you don't need to worry about exercising it fully in an e2e.

[gregmagolan]

Yup. Agreed that e2e/bzlmod & e2e/workspace are just smoke tests. Since we're not in a rush to land this @thesayyn we may as well take the opportunity to combine e2e/workspace & e2e/bzlmod into a single e2e/workspace and add the bzlmodEnabled: [true, false] pattern to CI for bazel-lib which @kormide just rolled out in rules_js: https://github.com/aspect-build/rules_js/blob/047decb02a7e1497d23cfb9b239b56778ea19f4d/.github/workflows/ci.yaml#L132

[gregmagolan]

@alexeagle is going to configure our preferred pattern for bzlmod/workspace smoketest e2e in rules_swc. Lets wait until that lands and then copy it over here.

[alexeagle]

Working on that right now...

[alexeagle]

aspect-build/rules_swc#153

[alexeagle]

@thesayyn should be unblocked now

[thesayyn]

oh, I missed this one. I'll takeover thanks!

[thesayyn]

now, this is more of a coreutils + e2e cleanup.

[thesayyn]

this is ready now

[kormide]

• Can we rename e2e/workspace to e2e/smoke? (.bcr/presubmit.yml also needs to reference this target)`.
• Each e2e should also have a WORKSPACE.bzlmod file, which tells Bazel to ignore WORKSPACE when bzlmod is enabled, and any repository rules can't be set up under MODULE.bazel go in there.

[alexeagle]

This broke the windows build on mainppp

[gregmagolan]

Looks like a small typo. #395 to fix