Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: always include files from the same workspace as the build target in copy_to_directory() #360

Merged
merged 3 commits into from
Oct 10, 2023
Merged

fix: always include files from the same workspace as the build target in copy_to_directory() #360

merged 3 commits into from
Oct 10, 2023

Commits on Oct 10, 2023

  1. fix: always include files from the same workspace as the build target… 

    … in `copy_to_directory`

Fixes bazel-contrib#359.

This updates the `copy_to_directory` tool to accept a workspace name representing the workspace of the target it is executing under. Any files in this workspace are automatically included, regardless of the `include_external_repositories` option. This makes it support usage within an external target (such as `@wksp//:dir`).
    @dgp1130
    dgp1130 committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    2adb96a View commit details
    Browse the repository at this point in the history

  2. test: add e2e test which uses copy_to_directory within an external … 

    …workspace

Refs bazel-contrib#359.

This should catch regressions where no files are copied when built within an external workspace and not using `include_external_repositories`.
    @dgp1130
    dgp1130 committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    2d313ee View commit details
    Browse the repository at this point in the history

  3. ci: fix stray workspace refs

    @alexeagle
    alexeagle committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    3d01672 View commit details
    Browse the repository at this point in the history