Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect 'find -type' argument used on MacOS #366

Merged
merged 1 commit into from
Feb 14, 2023

Conversation

acordiner
Copy link
Contributor

Within write_source_file(), an incorrect find argument is being used on MacOS to iterate over the copied files. Instead of find -type f, it is using find -type file, which produces an error:

find: Must separate multiple arguments to -type using: ','

@CLAassistant
Copy link

CLAassistant commented Feb 13, 2023

CLA assistant check
All committers have signed the CLA.

@gregmagolan
Copy link
Contributor

Hmm. Something is fishy here. I'm able to run

$ find . -type file | wc -l
    2642

on my macbook without any issues.

@gregmagolan gregmagolan added bug Something isn't working wip Work-in-progress; not ready for a final review or for landing labels Feb 14, 2023
@gregmagolan
Copy link
Contributor

Oh I see. Some implementations of file are tolerant of the additional chars in -type but your change is correct.

@gregmagolan gregmagolan removed the wip Work-in-progress; not ready for a final review or for landing label Feb 14, 2023
@gregmagolan gregmagolan merged commit 34d0557 into bazel-contrib:main Feb 14, 2023
@acordiner
Copy link
Contributor Author

Thanks @gregmagolan! Any chance to get this released?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants