Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update recommend CI flags from Workflows #378

Merged
merged 1 commit into from
Feb 22, 2023
Merged

fix: update recommend CI flags from Workflows #378

merged 1 commit into from
Feb 22, 2023

Conversation

mattem
Copy link
Contributor

@mattem mattem commented Feb 22, 2023

No description provided.

@gregmagolan
Copy link
Collaborator

Thanks for consolidating these @mattem

The SoT for these settings in in bazel-lib actually 🤷 https://github.com/aspect-build/bazel-lib/tree/main/.aspect/bazelrc

PR needs to go there and then silo gets the update when bazel-lib is updated via write_source_files.

@mattem
Copy link
Contributor Author

mattem commented Feb 22, 2023 •
edited
Loading

The SoT for these settings in in bazel-lib actually 🤷 https://github.com/aspect-build/bazel-lib/tree/main/.aspect/bazelrc
PR needs to go there and then silo gets the update when bazel-lib is updated via write_source_files.

This PR is against bazel-lib, so I don't understand what you're referring to here.

@gregmagolan
Copy link
Collaborator

The SoT for these settings in in bazel-lib actually 🤷 https://github.com/aspect-build/bazel-lib/tree/main/.aspect/bazelrc

PR needs to go there and then silo gets the update when bazel-lib is updated via write_source_files.

This PR is against bazel-lib, so I don't understand what you're referring to here.

🤦

@gregmagolan gregmagolan mentioned this pull request Feb 22, 2023
Merged
@gregmagolan gregmagolan added enhancement New feature or request cleanup Cleanup task labels Feb 22, 2023
@gregmagolan gregmagolan changed the title feat: update recommend CI flags from Workflows fix: update recommend CI flags from Workflows Feb 22, 2023
@gregmagolan gregmagolan self-requested a review February 22, 2023 23:34
@gregmagolan gregmagolan merged commit 09c08e4 into main Feb 22, 2023
@gregmagolan gregmagolan deleted the ciflags branch February 22, 2023 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregmagolan gregmagolan gregmagolan approved these changes

Assignees
No one assigned
Labels
cleanup Cleanup task enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattem @gregmagolan