Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove --experimental_guard_against_concurrent_changes from recommended correctness settings #380

Merged
merged 1 commit into from
Feb 23, 2023

Conversation

gregmagolan
Copy link
Collaborator

@gregmagolan gregmagolan commented Feb 23, 2023

We have observed that this settings leads to WARNINGS in npm package directory artifacts in the symlinked node_modules output tree created by rules_js for some npm packages.

For example,

WARNING: /private/tmp/f2/execroot/__main__/bazel-out/darwin-fastbuild/bin/node_modules/.aspect_rules_js/anymatch@3.1.3/node_modules/anymatch/LICENSE was modified during execution
WARNING: /private/tmp/f2/execroot/__main__/bazel-out/darwin-fastbuild/bin/node_modules/.aspect_rules_js/@ampproject+remapping@2.1.2/node_modules/@ampproject/remapping/LICENSE was modified during execution
WARNING: /private/tmp/f2/execroot/__main__/bazel-out/darwin-fastbuild/bin/node_modules/.aspect_rules_js/@esbuild+darwin-x64@0.17.8/node_modules/@esbuild/darwin-x64/bin/esbuild was modified during execution
WARNING: /private/tmp/f2/execroot/__main__/bazel-out/darwin-fastbuild/bin/node_modules/.aspect_rules_js/@apidevtools+json-schema-ref-parser@9.0.6/node_modules/@apidevtools/json-schema-ref-parser/CHANGELOG.md was modified during execution
WARNING: /private/tmp/f2/execroot/__main__/bazel-out/darwin-fastbuild/bin/node_modules/.aspect_rules_js/@cspotcode+source-map-support@0.8.1/node_modules/@cspotcode/source-[17[17,284 / 17,383] 26 actions running
    Compiling client/shared:shared_lib; 25s remote-cache, darwin-sandbox
WARNING: /private/tmp/f2/execroot/__main__/bazel-out/darwin-fastbuild/bin/node_modules/.aspect_rules_js/ansi-regex@2.1.1/node_modules/ansi-regex/aspect_rules_js_metadata.json was modified during execution
WARNING: /private/tmp/f2/execroot/__main__/bazel-out/darwin-fastbuild/bin/node_modules/.aspect_rules_js/@babel+runtime@7.20.6/node_modules/@babel/runtime/LICENSE was modified during execution
WARNING: /private/tmp/f2/execroot/__main__/bazel-out/darwin-fastbuild/bin/node_modules/.aspect_rules_js/@reach+auto-id@0.16.0_ef5jwxihqo6n7gxfmzogljlgcm/node_modules/@reach/utils was modified during execution
WARNING: /private/tmp/f2/execroot/__main__/bazel-out/darwin-fastbuild/bin/node_modules/.aspect_rules_js/@types+node@18.11.18/node_modules/@types/node/LICENSE was modified during execution

When this happens, it appears to make all downstream actions of that tree artifact the WARNING is for be cache misses.

Possibly related to bazelbuild/bazel#5566

@gregmagolan gregmagolan merged commit 91eeca7 into main Feb 23, 2023
@gregmagolan gregmagolan deleted the update_recommended_settings branch February 23, 2023 08:28
gregmagolan added a commit to aspect-build/aspect-cli that referenced this pull request Feb 28, 2023
Touch /docs folder to re-gen docsite with updated bazelrc
recommendations. See bazel-contrib/bazel-lib#380

GitOrigin-RevId: b4872cb2356df495590e89cda09afb2e2cb4d22d
gregmagolan added a commit to aspect-build/aspect-cli that referenced this pull request Feb 28, 2023
Touch /docs folder to re-gen docsite with updated bazelrc
recommendations. See bazel-contrib/bazel-lib#380

GitOrigin-RevId: b4872cb2356df495590e89cda09afb2e2cb4d22d
gregmagolan added a commit to aspect-build/aspect-cli that referenced this pull request Feb 28, 2023
Touch /docs folder to re-gen docsite with updated bazelrc
recommendations. See bazel-contrib/bazel-lib#380

GitOrigin-RevId: b4872cb2356df495590e89cda09afb2e2cb4d22d
gregmagolan added a commit to aspect-build/aspect-cli that referenced this pull request Feb 28, 2023
Touch /docs folder to re-gen docsite with updated bazelrc
recommendations. See bazel-contrib/bazel-lib#380

GitOrigin-RevId: b4872cb2356df495590e89cda09afb2e2cb4d22d
f0rmiga pushed a commit to aspect-build/talkie that referenced this pull request Aug 11, 2023
Touch /docs folder to re-gen docsite with updated bazelrc
recommendations. See bazel-contrib/bazel-lib#380
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants