-
-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: update YQ #405
Chore: update YQ #405
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update 🙏
@henkerik Are there breaking API changes in YQ between 4.25.2 to 4.33.3? Some of the existing test cases are failing with the change. |
@gregmagolan I made some minor changes to the testcases. You can review them here: |
@henkerik are there release notes describing the breaking changes? |
Thanks for updating the test cases. Looks like you just have to run |
@henkerik I rebased, updated docs one more time and force pushed. Will land and cut a minor release next. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🌮
It sure was! bazel-contrib/rules_oci#212 tripped on this, so any users of rules_oci who have a newer bazel-lib get an error from yq. I'm not sure what to do about this yet. I'm tempted to revert the |
The new version of yq is quite breaking, as it requires '-oj -r' for continued operation in rules_oci. We can do a default version flip later when more downstream projects are compatible.
The new version of yq is quite breaking, as it requires '-oj -r' for continued operation in rules_oci. We can do a default version flip later when more downstream projects are compatible.
The new version of yq is quite breaking, as it requires '-oj -r' for continued operation in rules_oci. We can do a default version flip later when more downstream projects are compatible.
The new version of yq is quite breaking, as it requires '-oj -r' for continued operation in rules_oci. We can do a default version flip later when more downstream projects are compatible.
Updated the list of available YQ versions. We would like to use a feature in a newer version. This may be a breaking change since the value of
DEFAULT_YQ_VERSION
is also updated in this PR.Type of change
For changes visible to end-users
Default YQ version change from
4.25.2
to4.33.3
.Test plan