feat: add list utils #512
Merged
feat: add list utils #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kormide
reviewed
Sep 18, 2023
kormide
reviewed
Sep 18, 2023
kormide
reviewed
Sep 18, 2023
kormide
reviewed
Sep 18, 2023
|
@alexeagle thanks for taking the time to make some extra work @kormide thanks for your review I really like your suggestions and will adopt them ❤️ |
|
Looks like this just needs a rebase to fix the test errors. |
mgred
force-pushed
the
add-list-functions
branch
2 times, most recently
from
6c03bef
to
54dfffb
Compare
mgred
force-pushed
the
add-list-functions
branch
from
54dfffb
to
232ffa0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds functions to work with lists from bzlparty/lib_common as discussed in #495.
I removed the
occursfunctions, this is not needed because of thein-operator.Please let me know if I should add more tests/documentation.
Type of change
For changes visible to end-users
Test plan