test - add bash script tests to CI

[jbedard]

No description provided.

[kormide]

What do you think about putting this in an e2e folder?

[kormide]

I find the .spec.sh extension a little awkward---makes me think it's a unit test.

[jbedard]

What do you think about putting this in an e2e folder?

I guess that's a better description? 🤷

I find the .spec.sh extension a little awkward---makes me think it's a unit test.

I'm open to whatever. Could be a subfolder that contains all the tests, or test.sh can be put in the root etc.

[kormide]

What do you think about putting this in an e2e folder?

I guess that's a better description? 🤷

I find the .spec.sh extension a little awkward---makes me think it's a unit test.

I'm open to whatever. Could be a subfolder that contains all the tests, or test.sh can be put in the root etc.

Personally prefer separating the e2e tests and putting them in one folder 🤷

[kormide]

Why _gitignored in the filename?

[jbedard]

That test is for writing files to a file that is gitignored and not controlled by bazel. The exit was me playing around making sure CI fails correctly

[jbedard]

Updated... the find command has been inlined into the CI file. It's a bit ugly but now we don't have to decide where to put a test.sh file. That command now executes a beautiful ---------------- testname.sh ------------- so you can actually understand the stdout and separation between the tests, it will fail and stop if any test fails.

Determining which files are executable seems to be a pita and differs per platform (mac is different then our ubuntu ci) so I'm doing *.sh instead of find-ing executable files (see https://stackoverflow.com/questions/4458120/search-for-executable-files-using-find-command). I dropped the *.spec pattern and just any shell scripts are assumed to be e2e tests.

[kormide]

LGTM

[jbedard]

You can see an example with 2 tests running in the other PR: https://github.com/aspect-build/bazel-lib/runs/5763137160