Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add undeclared output mode to expand_template #561

Merged
merged 1 commit into from
Sep 29, 2023

Conversation

gregmagolan
Copy link
Collaborator

@gregmagolan gregmagolan commented Sep 29, 2023

This is useful pattern in cases where you want to do a copy_to_bin because the output file must be in the same location and have the same name as the source file but want to do substitutions on the file that you are copying to bin.


Type of change

  • New feature or functionality (change which adds functionality)

Test plan

  • New test cases added

Copy link
Collaborator

@alexeagle alexeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YES! This is delightful, I think I've needed this before for tsconfig.json hacks

@gregmagolan gregmagolan merged commit bcb10f8 into main Sep 29, 2023
44 checks passed
@gregmagolan gregmagolan deleted the expand_template_implied_out branch September 29, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants