Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unconditionally use runfiles.merge_all in write_source_file #623

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Unconditionally use runfiles.merge_all in write_source_file #623

merged 1 commit into from
Oct 16, 2023

Conversation

dzbarsky
Copy link
Contributor

@dzbarsky dzbarsky commented Oct 12, 2023 •
edited
Loading

We are past Bazel 4.x LTS. lib/transitions.bzl is already using merge_all.

Type of change

  • Refactor (a code change that neither fixes a bug or adds a new feature)

Test plan

  • Covered by existing test cases

@jbedard jbedard merged commit a4f9994 into bazel-contrib:main Oct 16, 2023
25 checks passed
@dzbarsky dzbarsky deleted the merge_all branch October 16, 2023 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbedard jbedard jbedard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dzbarsky @jbedard