Remove ctx.resolve_tools() #656
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctx.resolve_tools() is slated for deprecation NO_BUG=cleanup
|
|
ctx.resolve_tools() is slated for deprecation Type of change Refactor (a code change that neither fixes a bug or adds a new feature) Test plan Covered by existing test cases
Replace `ctx.resolve_tools()` with `ctx.actions.run(tools = ..., ...)`
|
@ustamansangat is there documentation explaining this deprecation somewhere? This also seems to break things atm... |
|
This was merged in #763 |
|
Thanks @mishazharov (done in #763) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ctx.resolve_tools() is slated for deprecation
NO_BUG=cleanup
Type of change
Refactor (a code change that neither fixes a bug or adds a new feature)
Test plan
Covered by existing test cases