FR-723: make WriteSourceFileInfo public #724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregmagolan
approved these changes
Jan 23, 2024
gregmagolan
force-pushed
the
aspect-lib-723
branch
4 times, most recently
from
d2dfdfe
to
68c2234
Compare
gregmagolan
force-pushed
the
aspect-lib-723
branch
from
68c2234
to
ce58626
Compare
gregmagolan
added a commit
that referenced
this pull request
Mar 27, 2024
* FR-723: make WriteSourceFileInfo public * Update docs --------- Co-authored-by: Greg Magolan <greg@aspect.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Fixes #723
For changes visible to end-users
TODO: Update docs?
Make WriteSourceFileInfo public so end user rules can participate in additional_update_targets
Test plan
I've tested this by adding the provider to rules in our private repo and it works great