feat: add create_windows_native_launcher_script to lib/windows_utils.bzl #75
Conversation
| @@ -1,3 +1,17 @@ | |||
| # Copyright 2017 The Bazel Authors. All rights reserved. | |||
There was a problem hiding this comment.
Yes. It is copied over verbatim from rules_nodejs. Original author was Yun Ping. A few files in this repo that were copied verbatim have this copyright.
| content = r"""@echo off | ||
| SETLOCAL ENABLEEXTENSIONS | ||
| SETLOCAL ENABLEDELAYEDEXPANSION | ||
| set RUNFILES_MANIFEST_ONLY=1 |
There was a problem hiding this comment.
👋🏼 hi and sorry for the necromancy!
This effectively makes the windows launcher not remote executable. Is there a chance you could unset this value or make it configurable (all the way up to js_binary)? We'd also need to be able to change the filepath passed as bash_bin. Alternatively, why not assume the bash file is right next to the bat and let https://github.com/bazelbuild/bazel/blob/master/tools/bash/runfiles/runfiles.bash resolve correctly?
As it is, this makes js_binary (and derivatives) unusable on Windows RE setups. I don't know if this is documented/discussed in official bazel docs, but our docs on Windows RE & runfiles do cover this topic.
There was a problem hiding this comment.
Hi Richard. I don't have a lot of context on this launcher code. Original author was Yun Ping from the Bazel team back in the rules_nodejs days. I'm guessing this line is here because the local Windows case doesn't have runfiles so it assumes the only runfiles manifest is present, which doesn't work on RE. Windows RE is not something we have test coverage for here or in rules_js and not our top priority at the moment, however, I'd be happy review PRs for improving this code.
Very useful for rules_js