feat: yq #80
feat: yq #80
Conversation
kormide
force-pushed
the
yq
branch
13 times, most recently
from
f910d9c
to
2dccd08
Compare
lib/private/yq_toolchain.bzl
Outdated
| # https://github.com/mikefarah/yq/releases | ||
| # | ||
| # The integrity hashes can be computed with | ||
| # shasum -b -a 384 [downloaded file] | awk '{ print $1 }' | xxd -r -p | base64 | ||
| YQ_VERSIONS = { | ||
| "v4.24.4": { | ||
| "darwin_amd64": "sha384-H5JnUD7c0jpbOvvN1pGz12XFi3XrX+ism4iGnH9wv37i+qdkD2AdTbTe4MIFtMR+", | ||
| "darwin_arm64": "sha384-9B85+dFTGRmMWWP2M+PVOkl8CtAb/HV4+XNGC0OBfdBvdJU85FyiTb12XGEgNjFp", | ||
| "linux_386": "sha384-TiesqbEG9ITqnOyFNMilVnciVM65dCAlRNYp/pK19jrqs2x5MhbpJ0a7Q9XwZmz8", | ||
| "linux_amd64": "sha384-y8vr5fWIqSvJhMoHwldoVPOJpAfLi4iHcnhfTcm/nuJAxGAJmI2MiBbk3t7lQNHC", | ||
| "windows_386": "sha384-YJTz4Y+5rcy6Ii/J44Qb6J2JZuzfh40WHGTc6jFTHFhJ47Ht+y9s4bS6h8WX6S0m", | ||
| "windows_amd64": "sha384-f8jkaz3oRaDcn8jiXupeDO665t6d2tTnFuU0bKwLWszXSz8r29My/USG+UoO9hOr", | ||
| }, | ||
| } |
There was a problem hiding this comment.
@alexeagle Is there an easier way to automate this? This project is actively maintained, unlike jq.
There was a problem hiding this comment.
They publish checksums with each release
https://github.com/mikefarah/yq/releases/download/v4.24.5/checksums
so I'd guess this can just be a tiny script.
I just did rules_esbuild with a simple approach where we manually, periodically add a new version
https://github.com/aspect-build/rules_esbuild/blob/main/scripts/mirror_release.sh
We also have fancier integration in rules_nodejs to send auto-PRs when new versions are published, my guess is almost no users expect to have the very latest yq so not a very important place to invest time.
There was a problem hiding this comment.
Added a script to do this. See tools/yq_mirror_release.sh.
|
Ready for final review. |
kormide
force-pushed
the
yq
branch
2 times, most recently
from
2a909fc
to
82792f6
Compare
| @@ -12,7 +12,11 @@ tasks: | |||
| test_targets: | |||
| - "//..." | |||
| windows: | |||
There was a problem hiding this comment.
oh... this file does nothing right now :(
I think we probably aren't going to finish the project bazelbuild/continuous-integration#1313 so maybe we should just delete the file, but then we're still nowhere on getting test coverage :(
Maybe FasterCI could add platforms...
There was a problem hiding this comment.
Isn't this what controls the buildkite ci? See here: https://buildkite.com/bazel/bazel-lib/builds?branch=kormide%3Ayq
There was a problem hiding this comment.
oh wow ... we never get the webhooks back from buildkite so we don't post the statuses on PRs, so they are green regardless. How did you even know to look in buildkite there?
There was a problem hiding this comment.
Because I'm the one who set up buildkite :). And clearly forgot to add any sort of hooks..
There was a problem hiding this comment.
I don't think it was a forget thing - I tried to work with Yun and Florian to setup the webhooks into our github org but never saw evidence they were getting sent from bazel's buildkite. I guess we could pick that back up, want to work with them directly?
There was a problem hiding this comment.
Sure, happy to do that. But for my own understanding, why set up buildkite when we can use github actions? Can't we set up multiple platforms there?
There was a problem hiding this comment.
Yes, we could make Mac and windows under GitHub Actions, it's just another project.
There was a problem hiding this comment.
Ah and look at this bazelbuild/continuous-integration#1328
They have not done terraform applies? That is way too much toil for them to keep up with...
| return True | ||
| return False | ||
|
|
||
| def _escape_path(path): |
There was a problem hiding this comment.
did you check bazel_skylib//rules:paths.bzl to see if anything useful?
There was a problem hiding this comment.
Yeah I thought paths.relativize might do what we need but it doesn't.
| diff_test( | ||
| name = "case_json_output_no_out_test", | ||
| file1 = "//lib/tests/jq:a_pretty.json", | ||
| file2 = "case_json_output_no_out.json", |
There was a problem hiding this comment.
nice, I like the naming conventions that detect the output type
@alexeagle @gregmagolan
It turns out yq is quite functional and can parse and output to several different formats. This will help us convert our yaml pnpm lock to json in rules_js.
issue: #78
buildkite: https://buildkite.com/bazel/bazel-lib/builds?branch=kormide%3Ayq