Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix buildifier errors #81

Merged
merged 1 commit into from
Apr 15, 2022
Merged

chore: fix buildifier errors #81

merged 1 commit into from
Apr 15, 2022

Conversation

kormide
Copy link
Collaborator

@kormide kormide commented Apr 15, 2022

No description provided.

@kormide kormide requested a review from alexeagle April 15, 2022 20:18
alexeagle
alexeagle approved these changes Apr 15, 2022
View reviewed changes
Copy link
Collaborator

@alexeagle alexeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, want to wire up the CI enforcement for our stuff being buildifier-clean?
I haven't decided if it's really worth it for unimportant style nits.

@alexeagle
Copy link
Collaborator

If so, I think this buildifier-prebuilt approach is probably best, since pre-commit.ci doesn't seem to work
bazel-contrib/bazel-mypy-integration#50

@kormide kormide merged commit e0af963 into bazel-contrib:main Apr 15, 2022
@kormide kormide deleted the buildifier-fix branch April 15, 2022 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexeagle alexeagle alexeagle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kormide @alexeagle