fix: Set size to a default value as well as timeout. #839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
matts1
changed the title
rrbutani
reviewed
May 13, 2024
Currently, we are unable to run our `write_source_files` tests in our pre-upload checks, because we have `--test_size_filter=small`, and setting `size` will attempt to set it on both the run rule and the test rule, the former being invalid.
|
I just realized a better way to do it. Previously:
Now:
|
nya3jp
pushed a commit
to nya3jp/cros-bazel
that referenced
this pull request
May 14, 2024
Unfortunately, //bazel:generate_cargo_files_test does not run because it's not marked as small, and there's no way to mark it as small. This should be fixed by bazel-contrib/bazel-lib#839 BUG=None TEST=portage/tools/run_tests.sh Change-Id: Iea7b85df7d59b6f0bfaa6973a4e41119d9d6c102 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/bazel/+/5531394 Auto-Submit: Matt Stark <msta@google.com> Reviewed-by: Shuhei Takahashi <nya@chromium.org> Commit-Queue: Shuhei Takahashi <nya@chromium.org> Tested-by: Matt Stark <msta@google.com>
rrbutani
approved these changes
May 20, 2024
|
Any chance we can get this merged? |
alexeagle
reviewed
Jul 19, 2024
alexeagle
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we are unable to run our
write_source_filestests in our pre-upload checks, because we have--test_size_filter=small, and settingsizewill attempt to set it on both the run rule and the test rule, the former being invalid.See here for more details.
Changes are visible to end-users: no
Test plan
bazel test //... --test_size_filters=smallBefore: 5 tests run
After: 152 tests run