fix: add bzlmod use_repo of org_golang_x_sys #896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 3c121a9 broke E2E tests with the following error: ``` (23:31:56) ERROR: no such package '@@[unknown repo 'org_golang_x_sys' requested from @@aspect_bazel_lib~]//unix': The repository '@@[unknown repo 'org_golang_x_sys' requested from @@aspect_bazel_lib~]' could not be resolved: No repository visible as '@org_golang_x_sys' from repository '@@aspect_bazel_lib~' ``` The build worked when operating within the `aspect_bazel_lib` repo itself, but not when importing it with Bzlmod. This is because the `org_golang_x_sys` repo is imported indirectly by `rules_go`'s `go_rules_dependencies` macro in the `WORKSPACE` file, which is still active under bzlmod because there is no `WORKSPACE.bzlmod` file to suppress it.
jbedard
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 3c121a9 broke E2E tests with the following error:
The build worked when operating within the
aspect_bazel_librepo itself, but not when importing it with Bzlmod. This is because theorg_golang_x_sysrepo is imported indirectly byrules_go'sgo_rules_dependenciesmacro in theWORKSPACEfile, which is still active under bzlmod because there is noWORKSPACE.bzlmodfile to suppress it.Changes are visible to end-users: no
Test plan
Have confirmed that
e2e/copy_to_directoryande2e/external_copy_to_directorywere broken before this change and fixed after.