Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: turn off bzlmod misguided warning #901

Merged
merged 2 commits into from
Aug 14, 2024
Merged

chore: turn off bzlmod misguided warning #901

merged 2 commits into from
Aug 14, 2024

Conversation

alexeagle
Copy link
Collaborator

These are misinformed, the module resolver should be permitted to find an MVS solution

These are misinformed, the module resolver should be permitted to find an MVS solution
@alexeagle alexeagle requested a review from kormide August 14, 2024 02:49
Copy link

aspect-workflows bot commented Aug 14, 2024

Test

4 test targets passed

Targets
//lib/tests/copy_to_directory:case_22_test [k8-fastbuild]    115ms
//lib/tests/copy_to_directory_bin_action:test [k8-fastbuild] 217ms
//lib/tests/jq:check_stamped [k8-fastbuild]                  197ms
//lib/tests/yq:check_stamped [k8-fastbuild]                  396ms

Total test execution time was 925ms. 216 tests (98.2%) were fully cached saving 28s.


Test

e2e/copy_action

All tests were cache hits

1 test (100.0%) was fully cached saving 59ms.


Test

e2e/copy_to_directory

All tests were cache hits

6 tests (100.0%) were fully cached saving 750ms.


Test

e2e/coreutils

All tests were cache hits

4 tests (100.0%) were fully cached saving 742ms.


Test

e2e/external_copy_to_directory

All tests were cache hits

1 test (100.0%) was fully cached saving 59ms.


Test

e2e/smoke

All tests were cache hits

7 tests (100.0%) were fully cached saving 2s.


Buildifier

Buildifier managed files require formatting

--- ./e2e/smoke/BUILD.bazel	2024-08-14 16:28:06.999534955 +0000
+++ /tmp/buildifier-tmp-390748142	2024-08-14 16:28:53.714762934 +0000
@@ -116,11 +116,11 @@
 
 sh_test(
     name = "test_preserve_mtime",
+    size = "small",
     srcs = ["test_preserve_mtime.sh"],
     data = [
         "d",
-        ":copy_to_directory_mtime_case",
         ":copy_directory_mtime_case",
+        ":copy_to_directory_mtime_case",
     ],
-    size = "small",
 )

💡 Run the following to apply the suggested formatting fixes

bazel run //:buildifier

Format      Gazelle

@alexeagle alexeagle merged commit 385717a into main Aug 14, 2024
34 of 35 checks passed
@alexeagle alexeagle deleted the alexeagle-patch-2 branch August 14, 2024 17:41
@alexeagle
Copy link
Collaborator Author

FYI @gregmagolan - you didn't originally imagine this being a recommendation for our end users, but discussed: you don't feel strongly enough to revert this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants