Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #891 (requested by Bazel Open Source Support customer).
Changes are visible to end-users: yes
New function
split_args
is added to the public API ofstrings.bzl
.This fix touches a number of different rules:
jq
rule expansions now include make vars and rule fixed to single quote args that contain spacesexpand_template
optimized to not to bother with pointless.split(" ")
followed by" ".join()
bats_test
optimized to not to bother with pointless.split(" ")
followed by" ".join()
params_file
rule fixed to correctly split args on quotesrun_binary
rule fixed to correctly split args on quotesTest plan
Unit tests added for the new
split_args
function that handles parsing args and splitting them taking into account single quotes, double quotes and escapes.