Build fails on Bazel 8.0.0rc3

[mortenmj]

Build fails with an error when using 8.0.0rc3:

➜  bazel_features git:(main) ✗ bazel build //...
Starting local Bazel server and connecting to it...
WARNING: For repository 'bazel_skylib', the root module requires module version bazel_skylib@1.6.1, but got bazel_skylib@1.7.1 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'io_bazel_stardoc', the root module requires module version stardoc@0.6.2, but got stardoc@0.7.1 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
ERROR: Traceback (most recent call last):
        File "/home/vscode/.cache/bazel/_bazel_vscode/c972e14ded6d086e3efa57eaf11e9e05/external/+version_extension+bazel_features_globals/globals.bzl", line 10, column 79, in <toplevel>
                ProtoInfo = getattr(getattr(native, 'legacy_globals', None), 'ProtoInfo', ProtoInfo),
Error: predeclared variable 'ProtoInfo' is referenced before assignment.
WARNING: Target pattern parsing failed.
ERROR: Skipping '//...': error loading package under directory '': error loading package 'test': at /workspaces/bazel_features/test/test.bzl:5:6: at /workspaces/bazel_features/features.bzl:3:6: initialization of module 'globals.bzl' failed
ERROR: error loading package under directory '': error loading package 'test': at /workspaces/bazel_features/test/test.bzl:5:6: at /workspaces/bazel_features/features.bzl:3:6: initialization of module 'globals.bzl' failed
INFO: Elapsed time: 4.797s
INFO: 0 processes.
ERROR: Build did NOT complete successfully

[fmeum]

@comius

[cgrindel]

I can confirm that this does not happen on 8.0.0rc2.

[rickeylev]

Just relying a comment from chowder@ about possible cause:

@bazel_features evaluates 8.0.0rc3 to be "less than" 8.0.0, so it still thinks these are still valid globals.

[comius]

I believe version checks are wrong in bazel_features:

• ProtoInfo in bazel_features, used by protobuf: https://github.com/bazel-contrib/bazel_features/blob/main/private/globals.bzl#L27

Checks for workspace mode seem fine, but it doesn't hurt to double check:

• ProtoInfo in protobuf for workspace mode: https://github.com/protocolbuffers/protobuf/blob/v29.0-rc3/bazel/private/proto_bazel_features.bzl#L37
• Py*Info in rules_python for workspace mode: https://github.com/bazelbuild/rules_python/blob/main/python/private/internal_config_repo.bzl#L71
• https://github.com/bazelbuild/rules_java/blob/master/java/rules_java_deps.bzl#L9

[meteorcloudy]

Relevant discussion: #80 (comment)

[meteorcloudy]

@fmeum @Wyverald I think we should probably treat rcs the same as the final release instead of asking users to specify 8.0.0rc3? Otherwise, all versions specific in bazel_features should theoretically be rcs.

[fmeum]

@fmeum @Wyverald I think we should probably treat rcs the same as the final release instead of asking users to specify 8.0.0rc3? Otherwise, all versions specific in bazel_features should theoretically be rcs.

Over at #80 (comment), I still thought that "bazel_features is the one project to use exact version matching", but as this issue demonstrates that's just too much of a footgun. I'll send a PR to drop the rc suffix from comparisons in the same way as bazel_compatibility.

[rickeylev]

FYI for those subscribed: bazel_features 1.21.0 is released with a fix for this

[meteorcloudy]

8.0.0rc4 actually bumps the bazel_features by default, see bazelbuild/bazel@11596c3#diff-2bd581915487f6ba07e5ce4940d6c64969ffeb336664fb816189665631b7d018R15, so you probably don't have to do it manually.