Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .NET SDK 5.0.404 and bump nuget2bazel NuGet dependencies to 5.11.0 #271

Merged
merged 1 commit into from Jan 24, 2022
Merged

Conversation

ghost
Copy link

@ghost ghost commented Jan 24, 2022

rules_dotnet currently uses .NET SDK 5.0.201 which is affected by NuGet/Home#10491. This makes the rules unusable on Mac OSX.

When using the nuget2bazel tool, errors like the following appear:

Unhandled exception. NuGet.Packaging.Signing.SignatureException: Signed package validation failed with multiple errors:
NU3037: Package 'System.Buffers 4.5.1' from source 'https://api.nuget.org/v3/index.json': The author primary signature validity period has expired.
NU3037: Package 'System.Buffers 4.5.1' from source 'https://api.nuget.org/v3/index.json': The repository countersignature validity period has expired.

This change set bumps the default .NET SDK to 5.0.404 and upgrades the nuget2bazel NuGet dependencies for fetching packages to 5.11.0, which resolves the above issue.

@ghost ghost requested review from tomaszstrejczek and zaphar as code owners January 24, 2022 03:02
Copy link
Collaborator

@purkhusid purkhusid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for the contribution!

@purkhusid purkhusid merged commit 78f9b2a into bazel-contrib:master Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant