Remove Python 2 configuration and targets #1006
Conversation
Bazel is dropping support for Python 2 Work towards bazelbuild/bazel#17293
|
re: CI failure: The failing case is the "minimum supported version test" because @bazel_tools//tools/android:strip_resources wants to use Python 2. That was fixed back in 2019: bazelbuild/bazel@d93a146 As far as I can tell, that code is in the 4.0 release (which is what the CI is using, I think). So I'm not sure what's going on. |
Bazel 5 doesn't have this flag.
.bazelci/config.yaml
Outdated
| @@ -201,18 +201,13 @@ tasks: | |||
| - "--experimental_enable_aggregating_middleman=False" | |||
| min_supported_version_examples: | |||
| name: "Minimum Supported Version Examples" | |||
| bazel: "4.0.0" | |||
There was a problem hiding this comment.
Technically bazel 4 is still under LTS support until the end of this year and so I'd rather that we just disable the failing tests and keep this at 4 as the rest of these changes only affect the examples / tests and don't change the ability of this ruleset to continue support v4.
There was a problem hiding this comment.
I restored 4.0 as the min version.
I'll try my hand at modifying the config.yaml to skip the offending tests, but I might come back asking for some help on how to do so. (If you happen to have a link that explains these bazelci config files, that'd be great; the only thing i've found is https://github.com/bazelbuild/continuous-integration/blob/master/buildkite/README.md which doesn't explain many of the things i see or how to use them).
There was a problem hiding this comment.
OK, I think I figured it out.
Ready for another look
Bazel is dropping support for Python 2
Also raises the minimum Bazel version in the examples to 5.0, as 4.0 has built-in dependencies on Python 2.
Fixes #1005
Work towards bazelbuild/bazel#17293