fix meson tests for macOS CI #1260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsharpe
approved these changes
Aug 14, 2024
|
The first URL tried doesn't seem to exist: https://mirror.bazel.build/github.com/mesonbuild/meson/releases/download/1.5.1/meson-1.5.1.tar.gz I recognize this was copying the pattern from the other Meson versions. What is the process for getting this file to exist on |
jsharpe
pushed a commit
to jsharpe/rules_foreign_cc
that referenced
this pull request
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to fix the macOS CI issues mentioned in #1244.
Also noting #1251 disabled the broken tests. Whereas this MR should fix the tests.
The original problem should be a meson issue and not a foreign_cc one. see mesonbuild/meson#12574. Although, I couldn't track down what introduced the problem.
I got the idea that it is a meson problem, given
-Wl,--versionis not generated as a part of ourcxx_linker_executableorcxx_linker_shared.The quick solution is to update our default meson version to a version that includes the fix.
Had to also update glib, as after the meson fix it was running to this an issue similar to https://gitlab.gnome.org/GNOME/glib/-/issues/2995.