Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

toolchain_mappings: remove unnecessary arch constraints #456

Merged
merged 2 commits into from
Jan 22, 2021
Merged

toolchain_mappings: remove unnecessary arch constraints #456

merged 2 commits into from
Jan 22, 2021

Conversation

jesec
Copy link
Contributor

@jesec jesec commented Jan 16, 2021

This change allows rules_foreign_cc to work on architectures other
than x86_64.

Bug: bazelbuild/bazel#11628
Test: manual. no longer fails with "ln: illegal option -- t" on darwin_arm64

This change allows rules_foreign_cc to work on architectures other
than x86_64.

Bug: bazelbuild/bazel#11628
Test: manual. no longer fails with "ln: illegal option -- t" on darwin_arm64
@jesec jesec requested a review from oquenchil as a code owner January 16, 2021 02:02
@google-cla
Copy link

google-cla bot commented Jan 16, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@jesec
Copy link
Contributor Author

jesec commented Jan 16, 2021

@googlebot I signed it!

@whs-dot-hk
Copy link
Contributor

Look very legit to me the extra x86_64 condition was add during #196

whs-dot-hk added a commit to whs-dot-hk/whs_rules_foreign_cc that referenced this pull request Jan 21, 2021
* Add parallel make
* Fix PKG_CONFIG_PATH
* Fix pkgconfig
* Remove x86_64 restriction (bazel-contrib#456)
@whs-dot-hk whs-dot-hk mentioned this pull request Jan 21, 2021
@jsharpe jsharpe merged commit 75e7456 into bazel-contrib:master Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants