Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rules_go does not support identifying @io_bazel_rules_go with @ #2285

Closed
aehlig opened this issue Nov 19, 2019 · 2 comments
Closed

rules_go does not support identifying @io_bazel_rules_go with @ #2285

aehlig opened this issue Nov 19, 2019 · 2 comments
Labels
bug code-health

Comments

@aehlig
Copy link

aehlig commented Nov 19, 2019

What version of rules_go are you using?

HEAD, i.e., b8db84a

What version of gazelle are you using?

n/a

What version of Bazel are you using?

HEAD (after bazelbuild/bazel@81b57d6)

Does this issue reproduce with the latest releases of all the above?

n/a

What operating system and processor architecture are you using?

not OS specfic

Any other potentially useful information about your toolchain?

see https://github.com/bazelbuild/continuous-integration

What did you do?

https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/1281

What did you expect to see?

passing test

What did you see instead?

Futher information

rules_go assumes at various places that bazel-generated artifacts have a path starting with external. This is wrong if rules_go is the main repository. Examples include https://github.com/bazelbuild/rules_go/blob/b8db84a2f3fd7fac1801ddef376a549c2d83b682/go/tools/bazel_testing/bazel_testing.go#L297

Tracking issue is bazelbuild/bazel#10246

Background on the change bazelbuild/bazel#7130
jayconrod pushed a commit to jayconrod/rules_go that referenced this issue Nov 19, 2019
go/tools/bazel_testing: support location args without external prefix
6d69be9 
Previously, Bazel arguments resolved with $(location) or $(locations)
always included an "external/workspace/" prefix. We used this prefix
to map arguments to runfiles. Upcoming versions of Bazel won't add
this prefix to files in the main workspace.

Witht this change, bazel_testing will read the workspace name from the
WORKSPACE file from the main workspace (which must be among the
arguments). This makes sure that go_bazel_test targets in the main
workspace will continue to work.

Updates bazel-contrib#2285
@jayconrod jayconrod mentioned this issue Nov 19, 2019
Merged
jayconrod pushed a commit that referenced this issue Nov 19, 2019
go/tools/bazel_testing: support location args without external prefix (…
dd78c74 
…#2287)

Previously, Bazel arguments resolved with $(location) or $(locations)
always included an "external/workspace/" prefix. We used this prefix
to map arguments to runfiles. Upcoming versions of Bazel won't add
this prefix to files in the main workspace.

Witht this change, bazel_testing will read the workspace name from the
WORKSPACE file from the main workspace (which must be among the
arguments). This makes sure that go_bazel_test targets in the main
workspace will continue to work.

Updates #2285
@jayconrod
Copy link
Contributor

#2285 should fix this for newer integration tests (using go_bazel_test).

There are still a number of failing integration tests using the old bazel_test framework. It will take a few days to migrate those tests to the new bazel_test framework (#1959).

jayconrod pushed a commit to jayconrod/rules_go that referenced this issue Nov 20, 2019
tests/core/coverage: migrate to go_bazel_test
78605cb 
Updates bazel-contrib#2285
jayconrod pushed a commit to jayconrod/rules_go that referenced this issue Nov 20, 2019
tests/core/coverage: migrate to go_bazel_test
959f752 
Updates bazel-contrib#2285
@jayconrod jayconrod mentioned this issue Nov 20, 2019
Merged
jayconrod pushed a commit that referenced this issue Nov 20, 2019
tests/core/coverage: migrate to go_bazel_test (#2288)
3c4bce0 
Updates #2285
jayconrod pushed a commit to jayconrod/rules_go that referenced this issue Nov 20, 2019
tests/core/nogo: migrate to go_bazel_test
3b2a0a5 
Updates bazel-contrib#2285
@jayconrod jayconrod mentioned this issue Nov 20, 2019
Merged
jayconrod pushed a commit that referenced this issue Nov 21, 2019
tests/core/nogo: migrate to go_bazel_test (#2289)
1d299a6 
Updates #2285
jayconrod pushed a commit to jayconrod/rules_go that referenced this issue Nov 25, 2019
Migrate //tests/core/race to go_bazel_test
0eebe8d 
Updates bazel-contrib#2285
@jayconrod jayconrod mentioned this issue Nov 25, 2019
Merged
jayconrod pushed a commit that referenced this issue Nov 25, 2019
Migrate //tests/core/race to go_bazel_test (#2293)
ce0a245 
Updates #2285
jayconrod pushed a commit to jayconrod/rules_go that referenced this issue Nov 27, 2019
Migrate legacy tests to //tests/core/go_download_sdk (a go_bazel_test)
a0149d6 
Updates bazel-contrib#2285
@jayconrod jayconrod mentioned this issue Nov 27, 2019
Merged
jayconrod pushed a commit that referenced this issue Nov 27, 2019
Migrate legacy tests to //tests/core/go_download_sdk (a go_bazel_test) (
9961a13 
#2296)

Updates #2285
jayconrod pushed a commit to jayconrod/rules_go that referenced this issue Nov 27, 2019
Remove //tests/legacy/cgo_library_root_dir
f1fb61c 
Seems redundant with other tests.

Updates bazel-contrib#2285
@jayconrod jayconrod mentioned this issue Nov 27, 2019
Merged
jayconrod pushed a commit to jayconrod/rules_go that referenced this issue Nov 27, 2019
Migrate legacy test to //tests/core/go_test:test_filter_test
1dc4b7b 
Updates bazel-contrib#2285
@jayconrod jayconrod mentioned this issue Nov 27, 2019
Merged
jayconrod pushed a commit that referenced this issue Nov 27, 2019
Migrate legacy test to //tests/core/go_test:test_filter_test (#2298)
dcbf21f 
Updates #2285
jayconrod pushed a commit that referenced this issue Nov 27, 2019
Remove //tests/legacy/cgo_library_root_dir (#2297)
38a13ed 
Seems redundant with other tests.

Updates #2285
jayconrod pushed a commit to jayconrod/rules_go that referenced this issue Nov 27, 2019
Migrate reproducibility test to go_bazel_test
4150034 
Note that a cgo go_binary with the defualt link mode does not seem to
be reproducible on macOS. The original test did not cover this. Needs
investigation.

Updates bazel-contrib#2285
@jayconrod jayconrod mentioned this issue Nov 27, 2019
Merged
jayconrod pushed a commit that referenced this issue Dec 2, 2019
Migrate reproducibility test to go_bazel_test (#2299)
b5d51a6 
Note that a cgo go_binary with the defualt link mode does not seem to
be reproducible on macOS. The original test did not cover this. Needs
investigation.

Updates #2285
jayconrod pushed a commit to jayconrod/rules_go that referenced this issue Dec 2, 2019
tests/legacy/trans_dep_error: delete test
8eb947b 
This is the bazel_test. It checks whether a package can be imported as
both a direct and transitive dependency.

This test provides little value and is not worth migrating to
go_bazel_test, so deleting.

Updates bazel-contrib#2285
@jayconrod jayconrod mentioned this issue Dec 2, 2019
Merged
jayconrod pushed a commit that referenced this issue Dec 2, 2019
tests/legacy/trans_dep_error: delete test (#2303)
3efdc83 
This is the bazel_test. It checks whether a package can be imported as
both a direct and transitive dependency.

This test provides little value and is not worth migrating to
go_bazel_test, so deleting.

Updates #2285
@jayconrod
Copy link
Contributor

As of #2303, all the rules_go tests have been upgraded to use the new test framework, which is fixed with respect to this flag. I'll delete the old test framework shortly.

I'll wait to make sure the next run of https://buildkite.com/bazel/bazel-at-head-plus-downstream is fixed before closing this.

jayconrod pushed a commit that referenced this issue Dec 4, 2019
go/tools/bazel_testing: support location args without external prefix (…
ebcf756 
…#2287)

Previously, Bazel arguments resolved with $(location) or $(locations)
always included an "external/workspace/" prefix. We used this prefix
to map arguments to runfiles. Upcoming versions of Bazel won't add
this prefix to files in the main workspace.

Witht this change, bazel_testing will read the workspace name from the
WORKSPACE file from the main workspace (which must be among the
arguments). This makes sure that go_bazel_test targets in the main
workspace will continue to work.

Updates #2285
jayconrod pushed a commit that referenced this issue Dec 4, 2019
tests/core/coverage: migrate to go_bazel_test (#2288)
3ede4e9 
Updates #2285
jayconrod pushed a commit that referenced this issue Dec 4, 2019
tests/core/nogo: migrate to go_bazel_test (#2289)
9619cfd 
Updates #2285
jayconrod pushed a commit that referenced this issue Dec 4, 2019
Migrate //tests/core/race to go_bazel_test (#2293)
4c63305 
Updates #2285
jayconrod pushed a commit that referenced this issue Dec 4, 2019
Migrate legacy tests to //tests/core/go_download_sdk (a go_bazel_test) (
0a3507f 
#2296)

Updates #2285
jayconrod pushed a commit that referenced this issue Dec 4, 2019
Migrate legacy test to //tests/core/go_test:test_filter_test (#2298)
b851de0 
Updates #2285
jayconrod pushed a commit that referenced this issue Dec 4, 2019
Remove //tests/legacy/cgo_library_root_dir (#2297)
b57e777 
Seems redundant with other tests.

Updates #2285
jayconrod pushed a commit that referenced this issue Dec 4, 2019
Migrate reproducibility test to go_bazel_test (#2299)
14bf98f 
Note that a cgo go_binary with the defualt link mode does not seem to
be reproducible on macOS. The original test did not cover this. Needs
investigation.

Updates #2285
jayconrod pushed a commit that referenced this issue Dec 4, 2019
tests/legacy/trans_dep_error: delete test (#2303)
f06f376 
This is the bazel_test. It checks whether a package can be imported as
both a direct and transitive dependency.

This test provides little value and is not worth migrating to
go_bazel_test, so deleting.

Updates #2285
jayconrod pushed a commit that referenced this issue Dec 4, 2019
go/tools/bazel_testing: support location args without external prefix (…
fe4ffcf 
…#2287)

Previously, Bazel arguments resolved with $(location) or $(locations)
always included an "external/workspace/" prefix. We used this prefix
to map arguments to runfiles. Upcoming versions of Bazel won't add
this prefix to files in the main workspace.

Witht this change, bazel_testing will read the workspace name from the
WORKSPACE file from the main workspace (which must be among the
arguments). This makes sure that go_bazel_test targets in the main
workspace will continue to work.

Updates #2285
jayconrod pushed a commit that referenced this issue Dec 4, 2019
tests/core/coverage: migrate to go_bazel_test (#2288)
4b2ed07 
Updates #2285
jayconrod pushed a commit that referenced this issue Dec 4, 2019
tests/core/nogo: migrate to go_bazel_test (#2289)
1a08dd1 
Updates #2285
jayconrod pushed a commit that referenced this issue Dec 4, 2019
Migrate //tests/core/race to go_bazel_test (#2293)
5d8614b 
Updates #2285
jayconrod pushed a commit that referenced this issue Dec 4, 2019
Migrate legacy tests to //tests/core/go_download_sdk (a go_bazel_test) (
4b1aea8 
#2296)

Updates #2285
jayconrod pushed a commit that referenced this issue Dec 4, 2019
Migrate legacy test to //tests/core/go_test:test_filter_test (#2298)
96ddb54 
Updates #2285
jayconrod pushed a commit that referenced this issue Dec 4, 2019
Remove //tests/legacy/cgo_library_root_dir (#2297)
ecf37e9 
Seems redundant with other tests.

Updates #2285
jayconrod pushed a commit that referenced this issue Dec 4, 2019
Migrate reproducibility test to go_bazel_test (#2299)
cd1dc92 
Note that a cgo go_binary with the defualt link mode does not seem to
be reproducible on macOS. The original test did not cover this. Needs
investigation.

Updates #2285
jayconrod pushed a commit that referenced this issue Dec 4, 2019
tests/legacy/trans_dep_error: delete test (#2303)
d17246e 
This is the bazel_test. It checks whether a package can be imported as
both a direct and transitive dependency.

This test provides little value and is not worth migrating to
go_bazel_test, so deleting.

Updates #2285
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug code-health
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jayconrod @aehlig