Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO NOT IMPORT: Use 0.29.1 in test #2242

Closed
wants to merge 1 commit into from

Conversation

meteorcloudy
Copy link
Contributor

No description provided.

@meteorcloudy meteorcloudy changed the title Use 0.29.1 in test DO NOT IMPORT: Use 0.29.1 in test Oct 11, 2019
@jayconrod
Copy link
Contributor

@meteorcloudy I started seeing test failures in CI on Windows yesterday. I assume this is related? My Windows laptop needs to be reinstalled, so I haven't investigated it yet.

The tests in question are based on go_bazel_test (see bazel_testing.go). Tests using this framework copy files into a test workspace, run bazel commands, and verify the results. The framework creates the test workspace under execroot and reuses it across tests to avoid large caches and slow startup times. Tests are tagged local and exclusive, so only one test runs at a time, without sandboxing.

I know this is pretty hacky and maybe not supported. If there's a simple fix or a better way in general to verify output of bazel commands within tests, please let me know.

@meteorcloudy
Copy link
Contributor Author

Yes, this is for debugging that Windows issue. Turned out to be a bug in 1.0: bazelbuild/bazel#9995

@meteorcloudy
Copy link
Contributor Author

@philwo is making a change to Bazelisk so that i can also point to a local Bazel binary. We can then make sure the rules_go tests invoke the Bazel built from HEAD instead of the latest stable version.

@jayconrod
Copy link
Contributor

Thanks for looking into this!

Should the tests get the bazel binary from another place? Currently, they rely on PATH. I remember when we used Jenkins, there was a BAZEL environment variable. Is that still recommended?

@meteorcloudy
Copy link
Contributor Author

I think it's fine to rely on bazel in PATH once bazelbuild/bazelisk#93 is deployed to CI. Because after that, Bazelisk will always point the same Bazel binary we are using to run the test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants