Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes com_google_protobuf reference #2444

Conversation

rodrigoaliste
Copy link

This fix enables direct copy-paste on the WORKSPACE file for bazel versions that don't handle strip_prefix automatically.

What type of PR is this?

Documentation

What does this PR do? Why is it needed?

Fixes the README reference of com_google_protobuf. Adds the strip_prefix so users don't spend minutes of their lives searching for the issue when getting the following error:

ERROR: error loading package '': Every .bzl file must have a corresponding package, but 
'@com_google_protobuf//:protobuf_deps.bzl' does not have one. Please create a BUILD file in the same or any parent directory. Note that this BUILD file does not need to do anything except exist.

This fix enables direct copy-paste for bazel versions that don't handle the strip_prefix automatically.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@jayconrod
Copy link
Contributor

Sorry, I can't review anything without a signed CLA.

Based on the description I'm guessing this is the same as #2442 and #2447 though.

@jayconrod jayconrod closed this Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants