Add automatic platform detection from inbound crosstool_top and cpu #2859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an inbound `crosstool_top` and `cpu` are specified, some platforms can be automatically inferred/detected. Some legacy rules still implement configuration splits on `crosstool_top` and `cpu` instead of platform constaints. This is the case most notably for rules_apple and rules_android. Add a generic platform matching system based on `crostool_top`/`cpu`. Finally, add Apple and Android matchers. Signed-off-by: Steeve Morin <steeve@zen.ly>
The -framework flag needs to have its value in the same or clause. This fixed boostraping stdlib on iOS. Signed-off-by: Steeve Morin <steeve@zen.ly>
jayconrod
approved these changes
May 14, 2021
|
You should have merge power btw, so I'll leave it up to you to hit the button! |
fmeum
added a commit
to fmeum/rules_go
that referenced
this pull request
Mar 1, 2023
…nd cpu (bazel-contrib#2859)" This reverts commit 026db6d.
fmeum
added a commit
to fmeum/rules_go
that referenced
this pull request
Mar 1, 2023
…nd cpu (bazel-contrib#2859)" This reverts commit 026db6d.
fmeum
added a commit
to fmeum/rules_go
that referenced
this pull request
Apr 19, 2023
…nd cpu (bazel-contrib#2859)" This reverts commit 026db6d. Bazel is migrating to platforms and toolchains resolution, but this logic frequently reset platforms back based on the value of the legacy `--cpu` and `--crosstool_top` flags. Instead, users of rules that still rely on these flags should use the `platform_mappings` file.
fmeum
added a commit
to fmeum/rules_go
that referenced
this pull request
Apr 19, 2023
…nd cpu (bazel-contrib#2859)" This reverts commit 026db6d. Bazel is migrating to platforms and toolchains resolution, but this logic frequently reset platforms back based on the value of the legacy `--cpu` and `--crosstool_top` flags. Instead, users of rules that still rely on these flags should use the `platform_mappings` file.
fmeum
added a commit
to fmeum/rules_go
that referenced
this pull request
Apr 19, 2023
…nd cpu (bazel-contrib#2859)" This reverts commit 026db6d. Bazel is migrating to platforms and toolchains resolution, but this logic frequently reset platforms back based on the value of the legacy `--cpu` and `--crosstool_top` flags. Instead, users of rules that still rely on these flags should use the `platform_mappings` file.
fmeum
added a commit
to fmeum/rules_go
that referenced
this pull request
Apr 19, 2023
…nd cpu (bazel-contrib#2859)" This reverts commit 026db6d. Bazel is migrating to platforms and toolchains resolution, but this logic frequently reset platforms back based on the value of the legacy `--cpu` and `--crosstool_top` flags. Instead, users of rules that still rely on these flags should use the `platform_mappings` file.
fmeum
added a commit
that referenced
this pull request
Apr 19, 2023
…nd cpu (#2859)" (#3468) This reverts commit 026db6d. Bazel is migrating to platforms and toolchains resolution, but this logic frequently reset platforms back based on the value of the legacy `--cpu` and `--crosstool_top` flags. Instead, users of rules that still rely on these flags should use the `platform_mappings` file.
tingilee
pushed a commit
to tingilee/rules_go
that referenced
this pull request
Jul 19, 2023
…nd cpu (bazel-contrib#2859)" (bazel-contrib#3468) This reverts commit 026db6d. Bazel is migrating to platforms and toolchains resolution, but this logic frequently reset platforms back based on the value of the legacy `--cpu` and `--crosstool_top` flags. Instead, users of rules that still rely on these flags should use the `platform_mappings` file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reopens #2451
When an inbound
crosstool_topandcpuare specified, some platformscan be automatically inferred/detected.
Some legacy rules still implement configuration splits on
crosstool_topandcpuinstead of platform constaints. This is thecase most notably for rules_apple and rules_android.
Add a generic platform matching system based on
crostool_top/cpu.Finally, add Apple and Android matchers.
Refs #2443