Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transition on edges not self #3116

Merged
merged 3 commits into from
Jun 23, 2022
Merged

Transition on edges not self #3116

merged 3 commits into from
Jun 23, 2022

Commits on Jun 20, 2022

  1. Transition on edges not self 

    As per bazelbuild/bazel#15157 currently we
can't configure any transition-relevant attributes using select. This is
because we use self-transitions on targets, and when this happens,
configurable attributes aren't passed to the transition, so we make
incorrect transition decisions.

We only actually consult configuration data in `_go_context_data`, so we
only actually need to transition on the edges which (transitively) reach
a `_go_context_data`, which is `_go_context_data` itself and `deps`.
    @illicitonion
    illicitonion committed Jun 20, 2022
    Configuration menu
    Copy the full SHA
    2f9a9b0 View commit details
    Browse the repository at this point in the history

  2. Review comments

    @illicitonion
    illicitonion committed Jun 20, 2022
    Configuration menu
    Copy the full SHA
    c92a034 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2022

  1. Re-add go_library non_go_transition

    @illicitonion
    illicitonion committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    f19c329 View commit details
    Browse the repository at this point in the history