go_register_toolchains: update sdk_kinds #3511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After 89e3296, we have renamed _go_download_sdk to go_download_sdk_rule so that we could re-use the implementation inside the Bazel Module Extension setup. Update go_register_toolchains to pick up this change.
|
@sluongng I think that the other names changed as well, could you update them as well? |
fmeum
approved these changes
Apr 2, 2023
sluongng
added a commit
to buildbuddy-io/buildbuddy
that referenced
this pull request
Apr 10, 2023
linzhp
pushed a commit
that referenced
this pull request
Apr 20, 2023
* go_register_toolchains: update sdk_kinds After 89e3296, we have renamed _go_download_sdk to go_download_sdk_rule so that we could re-use the implementation inside the Bazel Module Extension setup. Update go_register_toolchains to pick up this change. * Update sdk.bzl
tingilee
pushed a commit
to tingilee/rules_go
that referenced
this pull request
Jul 19, 2023
* go_register_toolchains: update sdk_kinds After 89e3296, we have renamed _go_download_sdk to go_download_sdk_rule so that we could re-use the implementation inside the Bazel Module Extension setup. Update go_register_toolchains to pick up this change. * Update sdk.bzl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
After 89e3296, we have renamed
_go_download_sdk to go_download_sdk_rule so that we could re-use the
implementation inside the Bazel Module Extension setup.
Update go_register_toolchains to pick up this change.
Which issues(s) does this PR fix?
Fixes #3510
Other notes for review