Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Also build the repo with Bzlmod enabled #3801

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Also build the repo with Bzlmod enabled #3801

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b921cba
Also build the repo with Bzlmod enabled
fmeum Dec 27, 2023
5940af7
m
fmeum Dec 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion .bazelci/presubmit.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@ matrix:
- windows

tasks:
ubuntu1804_bazel400:
ubuntu1804_bazel540:
name: Ubuntu with minimum supported Bazel version
platform: ubuntu1804
bazel: 5.4.0 # test minimum supported version of bazel
shell_commands:
Expand All @@ -20,6 +21,7 @@ tasks:
- "-//tests/core/nogo/bzlmod/..."
ubuntu2004:
# enable some unflipped incompatible flags on this platform to ensure we don't regress.
name: Ubuntu with --config=incompatible
shell_commands:
- tests/core/cgo/generate_imported_dylib.sh
build_flags:
Expand All @@ -30,6 +32,23 @@ tasks:
- "//..."
test_targets:
- "//..."
ubuntu2004_bzlmod:
name: Ubuntu with Bzlmod
platform: ubuntu2004
shell_commands:
- tests/core/cgo/generate_imported_dylib.sh
build_flags:
- "--enable_bzlmod"
build_targets:
- "//..."
- "-//tests/extras/gomock:all"
- "-//tests/integration/googleapis:all"
test_flags:
- "--enable_bzlmod"
test_targets:
- "//..."
- "-//tests/extras/gomock:all"
- "-//tests/integration/googleapis:all"
debian11_zig_cc:
platform: debian11
shell_commands:
Expand Down
5 changes: 4 additions & 1 deletion .bazelrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,11 @@
common --enable_platform_specific_config
test --test_output=errors
# TODO: Temporarily disable while rules_go migrates to Bzlmod for its dev build.
# https://github.com/bazelbuild/bazel/issues/18958
common --noexperimental_enable_bzlmod
test --test_output=errors
# rules_go is not typically used as a root module, so we want our
# dependency versions to be as low as possible.
common --check_direct_dependencies=off

# Go requires a C toolchain that accepts options and emits errors like
# gcc or clang. The Go SDK does not support MSVC.
Expand Down
1 change: 1 addition & 0 deletions MODULE.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ bazel_dep(name = "bazel_skylib", version = "1.2.0")
bazel_dep(name = "platforms", version = "0.0.4")
bazel_dep(name = "rules_proto", version = "4.0.0")
bazel_dep(name = "protobuf", version = "3.19.2", repo_name = "com_google_protobuf")
bazel_dep(name = "stardoc", version = "0.6.2", repo_name = "io_bazel_stardoc")

go_sdk = use_extension("//go:extensions.bzl", "go_sdk")
go_sdk.download(
Expand Down
Loading