Print stack traces without panicking on test timeout #3833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@illicitonion Does this resolve the most pressing part of the issue for you? |
|
Yeah, this resolves the "tests may handle" part - the goleak part is still an issue but I'm on board with it potentially having a different solution. Thanks! |
|
I simplified this further and bumped the limit for stack sizes. |
tyler-french
approved these changes
Jan 17, 2024
cgrindel-self-hosted-renovate bot
referenced
this pull request
in cgrindel/bazel-starlib
Jan 19, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [io_bazel_rules_go](https://togithub.com/bazelbuild/rules_go) | http_archive | patch | `v0.45.0` -> `v0.45.1` | --- ### Release Notes <details> <summary>bazelbuild/rules_go (io_bazel_rules_go)</summary> ### [`v0.45.1`](https://togithub.com/bazelbuild/rules_go/releases/tag/v0.45.1) [Compare Source](https://togithub.com/bazelbuild/rules_go/compare/v0.45.0...v0.45.1) #### `WORKSPACE` code load("@​bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") http_archive( name = "io_bazel_rules_go", sha256 = "6734a719993b1ba4ebe9806e853864395a8d3968ad27f9dd759c196b3eb3abe8", urls = [ "https://mirror.bazel.build/github.com/bazelbuild/rules_go/releases/download/v0.45.1/rules_go-v0.45.1.zip", "https://github.com/bazelbuild/rules_go/releases/download/v0.45.1/rules_go-v0.45.1.zip", ], ) load("@​io_bazel_rules_go//go:deps.bzl", "go_register_toolchains", "go_rules_dependencies") go_rules_dependencies() go_register_toolchains(version = "1.21.6") #### What's Changed - Disable `layering_check` feature in CGo tests by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3829](https://togithub.com/bazelbuild/rules_go/pull/3829) - Print stack traces without panicking on test timeout by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3833](https://togithub.com/bazelbuild/rules_go/pull/3833) - Fix regression in empty `.go` file filtering for nogo by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3832](https://togithub.com/bazelbuild/rules_go/pull/3832) - release patch version 0.45.1 by [@​tyler-french](https://togithub.com/tyler-french) in [https://github.com/bazelbuild/rules_go/pull/3836](https://togithub.com/bazelbuild/rules_go/pull/3836) **Full Changelog**: bazel-contrib/rules_go@v0.45.0...v0.45.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDAuMCIsInVwZGF0ZWRJblZlciI6IjM2LjEwMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
renovate bot
referenced
this pull request
in kreempuff/rules_unreal_engine
Jan 19, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [io_bazel_rules_go](https://togithub.com/bazelbuild/rules_go) | http_archive | patch | `v0.45.0` -> `v0.45.1` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>bazelbuild/rules_go (io_bazel_rules_go)</summary> ### [`v0.45.1`](https://togithub.com/bazelbuild/rules_go/releases/tag/v0.45.1) [Compare Source](https://togithub.com/bazelbuild/rules_go/compare/v0.45.0...v0.45.1) #### `WORKSPACE` code load("@​bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") http_archive( name = "io_bazel_rules_go", sha256 = "6734a719993b1ba4ebe9806e853864395a8d3968ad27f9dd759c196b3eb3abe8", urls = [ "https://mirror.bazel.build/github.com/bazelbuild/rules_go/releases/download/v0.45.1/rules_go-v0.45.1.zip", "https://github.com/bazelbuild/rules_go/releases/download/v0.45.1/rules_go-v0.45.1.zip", ], ) load("@​io_bazel_rules_go//go:deps.bzl", "go_register_toolchains", "go_rules_dependencies") go_rules_dependencies() go_register_toolchains(version = "1.21.6") #### What's Changed - Disable `layering_check` feature in CGo tests by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3829](https://togithub.com/bazelbuild/rules_go/pull/3829) - Print stack traces without panicking on test timeout by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3833](https://togithub.com/bazelbuild/rules_go/pull/3833) - Fix regression in empty `.go` file filtering for nogo by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3832](https://togithub.com/bazelbuild/rules_go/pull/3832) - release patch version 0.45.1 by [@​tyler-french](https://togithub.com/tyler-french) in [https://github.com/bazelbuild/rules_go/pull/3836](https://togithub.com/bazelbuild/rules_go/pull/3836) **Full Changelog**: bazel-contrib/rules_go@v0.45.0...v0.45.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/kreempuff/rules_unreal_engine). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMzUuMCIsInVwZGF0ZWRJblZlciI6IjM3LjEzNS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
](https://renovatebot.com){kind=link}
cgrindel-self-hosted-renovate bot
referenced
this pull request
in cgrindel/rules_swift_package_manager
Jan 23, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [io_bazel_rules_go](https://togithub.com/bazelbuild/rules_go) | http_archive | minor | `v0.44.2` -> `v0.45.1` | --- ### Release Notes <details> <summary>bazelbuild/rules_go (io_bazel_rules_go)</summary> ### [`v0.45.1`](https://togithub.com/bazelbuild/rules_go/releases/tag/v0.45.1) [Compare Source](https://togithub.com/bazelbuild/rules_go/compare/v0.45.0...v0.45.1) #### `WORKSPACE` code load("@​bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") http_archive( name = "io_bazel_rules_go", sha256 = "6734a719993b1ba4ebe9806e853864395a8d3968ad27f9dd759c196b3eb3abe8", urls = [ "https://mirror.bazel.build/github.com/bazelbuild/rules_go/releases/download/v0.45.1/rules_go-v0.45.1.zip", "https://github.com/bazelbuild/rules_go/releases/download/v0.45.1/rules_go-v0.45.1.zip", ], ) load("@​io_bazel_rules_go//go:deps.bzl", "go_register_toolchains", "go_rules_dependencies") go_rules_dependencies() go_register_toolchains(version = "1.21.6") #### What's Changed - Disable `layering_check` feature in CGo tests by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3829](https://togithub.com/bazelbuild/rules_go/pull/3829) - Print stack traces without panicking on test timeout by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3833](https://togithub.com/bazelbuild/rules_go/pull/3833) - Fix regression in empty `.go` file filtering for nogo by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3832](https://togithub.com/bazelbuild/rules_go/pull/3832) - release patch version 0.45.1 by [@​tyler-french](https://togithub.com/tyler-french) in [https://github.com/bazelbuild/rules_go/pull/3836](https://togithub.com/bazelbuild/rules_go/pull/3836) **Full Changelog**: bazel-contrib/rules_go@v0.45.0...v0.45.1 ### [`v0.45.0`](https://togithub.com/bazelbuild/rules_go/releases/tag/v0.45.0) [Compare Source](https://togithub.com/bazelbuild/rules_go/compare/v0.44.2...v0.45.0) #### `WORKSPACE` code load("@​bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") http_archive( name = "io_bazel_rules_go", sha256 = "de7974538c31f76658e0d333086c69efdf6679dbc6a466ac29e65434bf47076d", urls = [ "https://mirror.bazel.build/github.com/bazelbuild/rules_go/releases/download/v0.45.0/rules_go-v0.45.0.zip", "https://github.com/bazelbuild/rules_go/releases/download/v0.45.0/rules_go-v0.45.0.zip", ], ) load("@​io_bazel_rules_go//go:deps.bzl", "go_register_toolchains", "go_rules_dependencies") go_rules_dependencies() go_register_toolchains(version = "1.21.6") #### What's Changed - nogo: use original source files instead of coverage-instrumented by [@​emmaxy](https://togithub.com/emmaxy) in [https://github.com/bazelbuild/rules_go/pull/3770](https://togithub.com/bazelbuild/rules_go/pull/3770) - Allow compilers to be overwritten in go_grpc_library() by [@​mering](https://togithub.com/mering) in [https://github.com/bazelbuild/rules_go/pull/3812](https://togithub.com/bazelbuild/rules_go/pull/3812) - update documentation for 0.44 by [@​tyler-french](https://togithub.com/tyler-french) in [https://github.com/bazelbuild/rules_go/pull/3813](https://togithub.com/bazelbuild/rules_go/pull/3813) - Temporarily undo deprecation of `//proto:go_grpc` by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3818](https://togithub.com/bazelbuild/rules_go/pull/3818) - Rename bazel_features polyfill to prevent conflicts by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3817](https://togithub.com/bazelbuild/rules_go/pull/3817) - Handle prerelease versions in polyfill by [@​illicitonion](https://togithub.com/illicitonion) in [https://github.com/bazelbuild/rules_go/pull/3821](https://togithub.com/bazelbuild/rules_go/pull/3821) - Extend gomock to allow passing an source_importpath instead of library when operating in source mode by [@​therve](https://togithub.com/therve) in [https://github.com/bazelbuild/rules_go/pull/3822](https://togithub.com/bazelbuild/rules_go/pull/3822) - Fix coverage collection with modified `COVERAGE_DIR` env variable by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3820](https://togithub.com/bazelbuild/rules_go/pull/3820) - improving logging for subcommand failure by [@​linzhp](https://togithub.com/linzhp) in [https://github.com/bazelbuild/rules_go/pull/3824](https://togithub.com/bazelbuild/rules_go/pull/3824) - release rules go 0.45.0 by [@​tyler-french](https://togithub.com/tyler-french) in [https://github.com/bazelbuild/rules_go/pull/3825](https://togithub.com/bazelbuild/rules_go/pull/3825) #### New Contributors - [@​emmaxy](https://togithub.com/emmaxy) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3770](https://togithub.com/bazelbuild/rules_go/pull/3770) - [@​therve](https://togithub.com/therve) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3822](https://togithub.com/bazelbuild/rules_go/pull/3822) **Full Changelog**: bazel-contrib/rules_go@v0.44.2...v0.45.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDAuMCIsInVwZGF0ZWRJblZlciI6IjM2LjEwMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
Feature
What does this PR do? Why is it needed?
It replaces a call to
panicin the timeout handler to just printing all stack traces, which removes the need to deregister theSIGTERMhandler when the test relies on particularSIGTERMbehavior at the cost of having Bazel kill the process after the grace period instead of thepanicdoing it right away.Also removes the
SIGTERMforwarding logic from the wrapper as it isn't needed: Bazel sendsSIGTERMto all child processes.Which issues(s) does this PR fix?
Related to #3827
Other notes for review