Keep order for PATH components #4252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The starlark `dict` already will return items in the order in which they where inserted on iteration. There is no need to explicitly sort the items. But it does break use cases, where the user has explicitly defined a order of `PATH` components. As for example is possible with the `env` attribute of `cc_args()` with the new `rule_cc` based toolchains.
jayconrod
approved these changes
Feb 7, 2025
There was a problem hiding this comment.
We chatted on Bazel Slack earlier. I don't remember why this was sorted originally, but I think it was paranoia to keep the path list in a deterministic order. The Starlark spec says that dict iteration order is deterministic, same as insertion order, so this paranoia was not justified.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do? Why is it needed?
The starlark
dictalready will return items in the order in which they where inserted on iteration. There is no need to explicitly sort the items. But it does break use cases, where the user has explicitly defined a order ofPATHcomponents. As for example is possible with theenvattribute ofcc_args()with the newrule_ccbased toolchains.Which issues(s) does this PR fix?
Fixes #
Other notes for review