Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass tag for java_test_lib #179

Merged
merged 1 commit into from
May 15, 2023

Conversation

lyao-77
Copy link
Contributor

@lyao-77 lyao-77 commented May 5, 2023

when we add no-tag to ignore linter checks for all test code, it only applies to test target. We need to make the expanded java_test_lib target inherit this behavior as well.

@lyao-77
Copy link
Contributor Author

lyao-77 commented May 12, 2023

Hi @illicitonion, can I get a review and approval for this small change? Thanks

Copy link
Collaborator

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

@illicitonion illicitonion merged commit b48fbad into bazel-contrib:main May 15, 2023
f0rmiga referenced this pull request in aspect-build/talkie Aug 11, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
|
[github.com/bazel-contrib/rules_jvm](https://togithub.com/bazel-contrib/rules_jvm)
| require | minor | `v0.13.0` -> `v0.14.0` |
|
[github.com/bazelbuild/rules_go](https://togithub.com/bazelbuild/rules_go)
| require | patch | `v0.40.0` -> `v0.40.1` |
|
[github.com/buildbarn/bb-clientd](https://togithub.com/buildbarn/bb-clientd)
| require | digest | `677f2e4` -> `25fd4b1` |
|
[github.com/buildbarn/bb-remote-execution](https://togithub.com/buildbarn/bb-remote-execution)
| require | digest | `13b8a35` -> `2b8c1fb` |
| [github.com/evanw/esbuild](https://togithub.com/evanw/esbuild) |
require | patch | `v0.18.10` -> `v0.18.11` |
| golang.org/x/mod | require | minor | `v0.11.0` -> `v0.12.0` |
|
[google.golang.org/genproto](https://togithub.com/googleapis/go-genproto)
| require | digest | `9b080da` -> `9506855` |
|
[google.golang.org/genproto/googleapis/api](https://togithub.com/googleapis/go-genproto)
| require | digest | `9b080da` -> `f517056` |
| [google.golang.org/grpc](https://togithub.com/grpc/grpc-go) | require
| patch | `v1.56.1` -> `v1.56.2` |

---

### ⚠ Dependency Lookup Warnings ⚠

Warnings were logged while processing this repo. Please check the
Dependency Dashboard for more information.

---

### Release Notes

<details>
<summary>bazel-contrib/rules_jvm
(github.com/bazel-contrib/rules_jvm)</summary>

###
[`v0.14.0`](https://togithub.com/bazel-contrib/rules_jvm/releases/tag/v0.14.0)

[Compare
Source](https://togithub.com/bazel-contrib/rules_jvm/compare/v0.13.0...v0.14.0)

WORKSPACE snippet:

```starlark
load("@&#8203;bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
http_archive(
    name = "contrib_rules_jvm",
    sha256 = "90ecdf08d7e8817b2247eea77826db872db8866da84b3a824f58d6661aca917f",
    strip_prefix = "rules_jvm-0.14.0",
    url = "https://github.com/bazel-contrib/rules_jvm/releases/download/v0.14.0/rules_jvm-v0.14.0.tar.gz",
)

### Fetches the contrib_rules_jvm dependencies.
### If you want to have a different version of some dependency,

### you should fetch it *before* calling this.
load("@&#8203;contrib_rules_jvm//:repositories.bzl", "contrib_rules_jvm_deps")

contrib_rules_jvm_deps()

### Now ensure that the downloaded deps are properly configured
load("@&#8203;contrib_rules_jvm//:setup.bzl", "contrib_rules_jvm_setup")

contrib_rules_jvm_setup()
```

#### What's Changed

- junit5: Print failure causes by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[https://github.com/bazel-contrib/rules_jvm/pull/175](https://togithub.com/bazel-contrib/rules_jvm/pull/175)
- Fix `tools/update-dependencies.sh` by
[@&#8203;rdesgroppes](https://togithub.com/rdesgroppes) in
[https://github.com/bazel-contrib/rules_jvm/pull/177](https://togithub.com/bazel-contrib/rules_jvm/pull/177)
- Bump PMD version to last planned release (6.55.0) by
[@&#8203;rdesgroppes](https://togithub.com/rdesgroppes) in
[https://github.com/bazel-contrib/rules_jvm/pull/178](https://togithub.com/bazel-contrib/rules_jvm/pull/178)
- pass tag for java_test_lib by
[@&#8203;lyao-77](https://togithub.com/lyao-77) in
[https://github.com/bazel-contrib/rules_jvm/pull/179](https://togithub.com/bazel-contrib/rules_jvm/pull/179)
- Add java_generate_proto directive by
[@&#8203;meowcakes](https://togithub.com/meowcakes) in
[https://github.com/bazel-contrib/rules_jvm/pull/181](https://togithub.com/bazel-contrib/rules_jvm/pull/181)
- Prepare for the next release by bumping deps by
[@&#8203;shs96c](https://togithub.com/shs96c) in
[https://github.com/bazel-contrib/rules_jvm/pull/182](https://togithub.com/bazel-contrib/rules_jvm/pull/182)

#### New Contributors

- [@&#8203;lyao-77](https://togithub.com/lyao-77) made their first
contribution in
[https://github.com/bazel-contrib/rules_jvm/pull/179](https://togithub.com/bazel-contrib/rules_jvm/pull/179)
- [@&#8203;meowcakes](https://togithub.com/meowcakes) made their first
contribution in
[https://github.com/bazel-contrib/rules_jvm/pull/181](https://togithub.com/bazel-contrib/rules_jvm/pull/181)

**Full Changelog**:
bazel-contrib/rules_jvm@v0.13.0...v0.14.0

</details>

<details>
<summary>bazelbuild/rules_go (github.com/bazelbuild/rules_go)</summary>

###
[`v0.40.1`](https://togithub.com/bazelbuild/rules_go/releases/tag/v0.40.1)

[Compare
Source](https://togithub.com/bazelbuild/rules_go/compare/v0.40.0...v0.40.1)

#### `WORKSPACE` code

load("@&#8203;bazel_tools//tools/build_defs/repo:http.bzl",
"http_archive")

    http_archive(
        name = "io_bazel_rules_go",
sha256 =
"51dc53293afe317d2696d4d6433a4c33feedb7748a9e352072e2ec3c0dafd2c6",
        urls = [

"https://mirror.bazel.build/github.com/bazelbuild/rules_go/releases/download/v0.40.1/rules_go-v0.40.1.zip",

"https://github.com/bazelbuild/rules_go/releases/download/v0.40.1/rules_go-v0.40.1.zip",
        ],
    )

load("@&#8203;io_bazel_rules_go//go:deps.bzl", "go_register_toolchains",
"go_rules_dependencies")

    go_rules_dependencies()

    go_register_toolchains(version = "1.20.5")

#### Changes

This patch release cherry-picked two bug fixes related to Go package
driver from master

-
[https://github.com/bazelbuild/rules_go/pull/3606](https://togithub.com/bazelbuild/rules_go/pull/3606)
-
[https://github.com/bazelbuild/rules_go/pull/3608](https://togithub.com/bazelbuild/rules_go/pull/3608)

</details>

<details>
<summary>evanw/esbuild (github.com/evanw/esbuild)</summary>

###
[`v0.18.11`](https://togithub.com/evanw/esbuild/releases/tag/v0.18.11)

[Compare
Source](https://togithub.com/evanw/esbuild/compare/v0.18.10...v0.18.11)

- Fix a TypeScript code generation edge case
([#&#8203;3199](https://togithub.com/evanw/esbuild/issues/3199))

This release fixes a regression in version 0.18.4 where using a
TypeScript `namespace` that exports a `class` declaration combined with
`--keep-names` and a `--target` of `es2021` or earlier could cause
esbuild to export the class from the namespace using an incorrect name
(notice the assignment to `X2._Y` vs. `X2.Y`):

    ```ts
    // Original code

    // Old output (with --keep-names --target=es2021)
    var X;
    ((X2) => {
      const _Y = class _Y {
      };
      __name(_Y, "Y");
      let Y = _Y;
      X2._Y = _Y;
    })(X || (X = {}));

    // New output (with --keep-names --target=es2021)
    var X;
    ((X2) => {
      const _Y = class _Y {
      };
      __name(_Y, "Y");
      let Y = _Y;
      X2.Y = _Y;
    })(X || (X = {}));
    ```

</details>

<details>
<summary>grpc/grpc-go (google.golang.org/grpc)</summary>

### [`v1.56.2`](https://togithub.com/grpc/grpc-go/releases/tag/v1.56.2):
Release 1.56.2

[Compare
Source](https://togithub.com/grpc/grpc-go/compare/v1.56.1...v1.56.2)

- status: To fix a panic, `status.FromError` now returns an error with
`codes.Unknown` when the error implements the `GRPCStatus()` method, and
calling `GRPCStatus()` returns `nil`.
([#&#8203;6374](https://togithub.com/grpc/grpc-go/issues/6374))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://togithub.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/aspect-build/silo).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xNDQuMiIsInVwZGF0ZWRJblZlciI6IjM1LjE1OS43IiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

---------

Signed-off-by: Thulio Ferraz Assis <3149049+f0rmiga@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Thulio Ferraz Assis <3149049+f0rmiga@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants