Factor detecting whether repo is unpinned into a shared helper

private/rules/coursier.bzl

@@ -137,6 +137,9 @@ def _is_file(repository_ctx, path):
 def _is_directory(repository_ctx, path):
  return repository_ctx.which("test") and repository_ctx.execute(["test", "-d", path]).return_code == 0
 
+def _is_unpinned(repository_ctx):
+ return repository_ctx.attr.name.startswith("unpinned_")
+
 def _shell_quote(s):
  # Lifted from
  # https://github.com/bazelbuild/bazel-skylib/blob/6a17363a3c27dde70ab5002ad9f2e29aff1e1f4b/lib/shell.bzl#L49
@@ -875,7 +878,7 @@ def make_coursier_dep_tree(
  cmd.append("--default=true")
 
  environment = {}
- if not repository_ctx.attr.name.startswith("unpinned_"):
+ if not _is_unpinned(repository_ctx):
  coursier_cache_location = get_coursier_cache_or_default(
  repository_ctx,
  False,
@@ -1009,7 +1012,7 @@ def _coursier_fetch_impl(repository_ctx):
  # TODO(jin): allow custom cache locations
  coursier_cache_path = get_coursier_cache_or_default(
  repository_ctx,
- repository_ctx.attr.name.startswith("unpinned_"),
+ _is_unpinned(repository_ctx),
  ).replace("//", "/")
 
  for artifact in dep_tree["dependencies"]:
@@ -1032,13 +1035,13 @@ def _coursier_fetch_impl(repository_ctx):
  # to file within the repository rule workspace
  print("Assuming maven local for artifact: %s" % artifact["coord"])
  artifact.update({"url": None})
- if not repository_ctx.attr.name.startswith("unpinned_"):
+ if not _is_unpinned(repository_ctx):
  artifact.update({"file": _relativize_and_symlink_file_in_maven_local(repository_ctx, artifact["file"])})
 
  files_to_inspect.append(repository_ctx.path(artifact["file"]))
  continue
 
- if repository_ctx.attr.name.startswith("unpinned_"):
+ if _is_unpinned(repository_ctx):
  artifact.update({"file": _relativize_and_symlink_file_in_coursier_cache(repository_ctx, artifact["file"], coursier_cache_path)})
 
  # Coursier saves the artifacts into a subdirectory structure
@@ -1231,12 +1234,12 @@ def _coursier_fetch_impl(repository_ctx):
  },
  override_targets = repository_ctx.attr.override_targets,
  # Skip maven local dependencies if generating the unpinned repository
- skip_maven_local_dependencies = repository_ctx.attr.name.startswith("unpinned_"),
+ skip_maven_local_dependencies = _is_unpinned(repository_ctx),
  )
 
  # This repository rule can be either in the pinned or unpinned state, depending on when
  # the user invokes artifact pinning. Normalize the repository name here.
- if repository_ctx.name.startswith("unpinned_"):
+ if _is_unpinned(repository_ctx):
  repository_name = repository_ctx.name[len("unpinned_"):]
  outdated_build_file_content = ""
  else: