Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes problem with bom file generation with Bazel 7 #1079

Merged
merged 6 commits into from
Apr 3, 2024

Conversation

shs96c
Copy link
Collaborator

@shs96c shs96c commented Mar 20, 2024

No description provided.

Copy link
Collaborator

@jin jin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shs96c
Copy link
Collaborator Author

shs96c commented Mar 21, 2024

I do need to add a test for this. Apparently we don't generate the required a Maven BOM in our existing repo. Should be easy to do.

I'll switch to same_package_label instead. I'd not noticed that API was deprecated. Thank you for the catch.

@shs96c
Copy link
Collaborator Author

shs96c commented Mar 23, 2024

I switched the java_export example to use bzlmod, and that demonstrated the problem pretty clearly. In the course of fixing that, I found that if people weren't fetching sources for their repos, then we weren't properly generating the build file iff the lock file being used had fetch_sources = True. That problem is also fixed, and was also highlighted by the java_export example.

@shs96c shs96c merged commit 269f2dd into bazel-contrib:master Apr 3, 2024
8 checks passed
@shs96c shs96c deleted the bazel7-bom-fix branch April 3, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants